Krinkle has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/342670 )

Change subject: build: Enable ESLint for tests/ and fix violations
......................................................................


build: Enable ESLint for tests/ and fix violations

Change-Id: I7dad93e07fcb5ebcc5cf900294443d45556b5ca5
---
M Gruntfile.js
M tests/ext.navigationTiming.test.js
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/Gruntfile.js b/Gruntfile.js
index 8d16173..fa15b69 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -15,7 +15,7 @@
                        all: 'i18n/'
                },
                eslint: {
-                       all: [ '*.js', 'modules/**/*.js' ]
+                       all: [ '*.js', '{modules,tests}/**/*.js' ]
                }
        } );
 
diff --git a/tests/ext.navigationTiming.test.js 
b/tests/ext.navigationTiming.test.js
index adc5c7b..1891b6d 100644
--- a/tests/ext.navigationTiming.test.js
+++ b/tests/ext.navigationTiming.test.js
@@ -1,5 +1,5 @@
 /* global mw */
-// eslint-env qunit
+/* eslint-env qunit */
 QUnit.module( 'ext.navigationTiming' );
 
 // Basic test will ensure no exceptions are thrown and various

-- 
To view, visit https://gerrit.wikimedia.org/r/342670
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7dad93e07fcb5ebcc5cf900294443d45556b5ca5
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/NavigationTiming
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to