Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343127 )
Change subject: Popups doesnt need to depend on EventLogging ...................................................................... Popups doesnt need to depend on EventLogging Use EventLoggingRegisterSchemas hook to register schema This has the same effect as ResourceLoader but doesn't require the hard dependency to EventLogging When EventLogging is unavailable schema returns a interface which is has a no operation log method to avoid exceptions being thrown when attempts to log are made. Bug: T158999 Change-Id: I7ed7f00d52279151ece23e5aced4f2adb0f7fdc3 --- M extension.json M includes/PopupsHooks.php M resources/dist/index.js M resources/dist/index.js.map M src/schema.js M tests/node-qunit/schema.test.js 6 files changed, 56 insertions(+), 12 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups refs/changes/27/343127/1 -- To view, visit https://gerrit.wikimedia.org/r/343127 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7ed7f00d52279151ece23e5aced4f2adb0f7fdc3 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Popups Gerrit-Branch: master Gerrit-Owner: Jdlrobson <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
