DLynch has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/343194 )
Change subject: Follow up ec559041: abort notices display early if no notices
......................................................................
Follow up ec559041: abort notices display early if no notices
This avoids attempting to toggle after a destroy call has been made.
Change-Id: Ia756ff6436ec0590639dbbff216c9999daf684ec
---
M modules/ve-mw/ui/tools/ve.ui.MWPopupTool.js
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/94/343194/1
diff --git a/modules/ve-mw/ui/tools/ve.ui.MWPopupTool.js
b/modules/ve-mw/ui/tools/ve.ui.MWPopupTool.js
index 799fd68..7759cf9 100644
--- a/modules/ve-mw/ui/tools/ve.ui.MWPopupTool.js
+++ b/modules/ve-mw/ui/tools/ve.ui.MWPopupTool.js
@@ -75,6 +75,7 @@
if ( !count ) {
this.destroy();
+ return;
}
this.popup.setLabel( ve.msg(
--
To view, visit https://gerrit.wikimedia.org/r/343194
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia756ff6436ec0590639dbbff216c9999daf684ec
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: DLynch <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
