John Erling Blad has submitted this change and it was merged.
Change subject: Added to QueryEngineResultTest
......................................................................
Added to QueryEngineResultTest
Change-Id: I5f2902d0e25f9ac10384571dab4812235bf177d5
---
M repo/includes/Query/QueryEngineResult.php
M repo/tests/phpunit/includes/Query/QueryEngineResultTest.php
2 files changed, 35 insertions(+), 2 deletions(-)
Approvals:
John Erling Blad: Verified; Looks good to me, approved
diff --git a/repo/includes/Query/QueryEngineResult.php
b/repo/includes/Query/QueryEngineResult.php
index 6991bd4..e90b648 100644
--- a/repo/includes/Query/QueryEngineResult.php
+++ b/repo/includes/Query/QueryEngineResult.php
@@ -31,10 +31,13 @@
class QueryEngineResult {
/**
+ * @since wd.qe
+ *
* @return QueryResult
*/
public function getQueryResult() {
-
+ // TODO
+ return new QueryResult();
}
}
\ No newline at end of file
diff --git a/repo/tests/phpunit/includes/Query/QueryEngineResultTest.php
b/repo/tests/phpunit/includes/Query/QueryEngineResultTest.php
index 1d3c620..72f190c 100644
--- a/repo/tests/phpunit/includes/Query/QueryEngineResultTest.php
+++ b/repo/tests/phpunit/includes/Query/QueryEngineResultTest.php
@@ -36,6 +36,36 @@
*/
class QueryEngineResultTest extends \MediaWikiTestCase {
- // TODO
+ /**
+ * @since wd.qe
+ *
+ * @return QueryEngineResult[]
+ */
+ protected function getInstances() {
+ $instances = array();
+
+ $instances[] = new QueryEngineResult();
+
+ return $instances;
+ }
+
+ /**
+ * @since wd.qe
+ *
+ * @return QueryEngineResult[][]
+ */
+ public function instanceProvider() {
+ return $this->arrayWrap( $this->getInstances() );
+ }
+
+ /**
+ * @dataProvider instanceProvider
+ *
+ * @param QueryEngineResult $engineResult
+ */
+ public function testGetResultReturnType( QueryEngineResult
$engineResult ) {
+ // TODO: switch type check to real object
+ $this->assertInstanceOf( 'Wikibase\Repo\Query\QueryResult',
$engineResult->getQueryResult() );
+ }
}
--
To view, visit https://gerrit.wikimedia.org/r/51038
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5f2902d0e25f9ac10384571dab4812235bf177d5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: Daniel Werner <[email protected]>
Gerrit-Reviewer: John Erling Blad <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
