Aude has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/343526 )
Change subject: Only do database test setup when tests require database
(needsDB)
......................................................................
Only do database test setup when tests require database (needsDB)
When running --exclude-group Database then we shouldn't
access the database, which this was doing.
Change-Id: Ie860134a5c2e933ef64d71d0b1213f1f52643880
---
M tests/phpunit/MediaWikiTestCase.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/26/343526/1
diff --git a/tests/phpunit/MediaWikiTestCase.php
b/tests/phpunit/MediaWikiTestCase.php
index 419ff00..35adbc1 100644
--- a/tests/phpunit/MediaWikiTestCase.php
+++ b/tests/phpunit/MediaWikiTestCase.php
@@ -367,7 +367,7 @@
$needsResetDB = false;
- if ( !self::$dbSetup || $this->needsDB() ) {
+ if ( $this->needsDB() ) {
// set up a DB connection for this test to use
self::$useTemporaryTables = !$this->getCliArg(
'use-normal-tables' );
--
To view, visit https://gerrit.wikimedia.org/r/343526
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie860134a5c2e933ef64d71d0b1213f1f52643880
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aude <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
