jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/343550 )
Change subject: Use Node.DOCUMENT_NODE rather than magic number
......................................................................
Use Node.DOCUMENT_NODE rather than magic number
All browsers we support have full support for DOM Level 2 now.
Change-Id: I217ba7dd21659418cea005806c8e4335ca3dc5e9
---
M src/Element.js
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
jenkins-bot: Verified
VolkerE: Looks good to me, approved
diff --git a/src/Element.js b/src/Element.js
index 3b9085d..94cc808 100644
--- a/src/Element.js
+++ b/src/Element.js
@@ -327,7 +327,7 @@
// Window
obj.document ||
// HTMLDocument
- ( obj.nodeType === 9 && obj ) ||
+ ( obj.nodeType === Node.DOCUMENT_NODE && obj ) ||
null;
};
@@ -356,7 +356,7 @@
if ( obj instanceof jQuery ) {
obj = obj[ 0 ];
}
- isDoc = obj.nodeType === 9;
+ isDoc = obj.nodeType === Node.DOCUMENT_NODE;
isWin = obj.document !== undefined;
if ( isDoc || isWin ) {
if ( isWin ) {
--
To view, visit https://gerrit.wikimedia.org/r/343550
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I217ba7dd21659418cea005806c8e4335ca3dc5e9
Gerrit-PatchSet: 2
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: VolkerE <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
