jenkins-bot has submitted this change and it was merged.
Change subject: Make maintenance/update.php parse again under PHP 4.1.0
......................................................................
Make maintenance/update.php parse again under PHP 4.1.0
The instanceof produces a parse error on old PHP versions,
which doesn't show the old-version error message.
Note that our is minimum PHP version is 5.3.2, so it won't
produce E_STRICTs (is_a() was undeprecated in 5.3.0)
Change-Id: I5904301759bd154dd87ed90a5176369e37346482
---
M maintenance/update.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Parent5446: Looks good to me, approved
jenkins-bot: Verified
diff --git a/maintenance/update.php b/maintenance/update.php
index ba1d8cd..159b6b7 100644
--- a/maintenance/update.php
+++ b/maintenance/update.php
@@ -154,7 +154,7 @@
$child = $this->runChild( $maint );
// LoggedUpdateMaintenance is checking the updatelog
itself
- $isLoggedUpdate = ( $child instanceof
LoggedUpdateMaintenance );
+ $isLoggedUpdate = is_a( $child,
'LoggedUpdateMaintenance' );
if ( !$isLoggedUpdate && $updater->updateRowExists(
$maint ) ) {
continue;
--
To view, visit https://gerrit.wikimedia.org/r/51021
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5904301759bd154dd87ed90a5176369e37346482
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Platonides <[email protected]>
Gerrit-Reviewer: Demon <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: Parent5446 <[email protected]>
Gerrit-Reviewer: Reedy <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
