Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/343757 )
Change subject: Feature flagged print styles
......................................................................
Feature flagged print styles
Currently no print styles are shipped.
The styles will be added in follow ups
Bug: T159857
Change-Id: Ic8b61b81c16a009721d635f133a72107d95b61d3
---
M README.md
M extension.json
M includes/skins/SkinMinerva.php
A resources/skins.minerva.print.styles/styles.less
4 files changed, 35 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/57/343757/1
diff --git a/README.md b/README.md
index e05d7b7..920b730 100644
--- a/README.md
+++ b/README.md
@@ -339,6 +339,19 @@
* Type: `Boolean`
* Default: `false`
+#### $wgMinervaPrintStyles
+
+A temporary configuration variable to control roll out of styles to improve
the MobileFrontend print experience.
+
+* Type: `Array`
+* Default:
+```php
+ [
+ 'beta' => true,
+ 'base' => false,
+ ]
+```
+
#### $wgMinervaUseHeaderV2
A temporary configuration variable to control display of a new header which
converts the search input
diff --git a/extension.json b/extension.json
index fb7e63c..ef3c3b8 100644
--- a/extension.json
+++ b/extension.json
@@ -153,6 +153,16 @@
"resources/mobile.pagesummary.styles/pagesummary.less"
]
},
+ "skins.minerva.print.styles": {
+ "targets": [
+ "mobile",
+ "desktop"
+ ],
+ "position": "top",
+ "styles": [
+
"resources/skins.minerva.print.styles/styles.less"
+ ]
+ },
"skins.minerva.tablet.styles": {
"targets": [
"mobile",
@@ -1801,6 +1811,10 @@
"MFContentNamespace": 0,
"MFDefaultSkinClass": "SkinMinerva",
"MinervaApplyKnownTemplateHacks": false,
+ "MinervaPrintStyles": {
+ "base": false,
+ "beta": true
+ },
"MinervaPageActions": [
"edit",
"talk",
diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php
index 1de9788..72b19ab 100644
--- a/includes/skins/SkinMinerva.php
+++ b/includes/skins/SkinMinerva.php
@@ -286,7 +286,12 @@
*/
public function initPage( OutputPage $out ) {
parent::initPage( $out );
- $out->addModuleStyles( 'mobile.usermodule.styles' );
+ $styles = [ 'mobile.usermodule.styles' ];
+ if ( $this->mobileContext->getConfigVariable(
'MinervaPrintStyles' ) ) {
+ $styles[] = 'skins.minerva.print.styles';
+ }
+
+ $out->addModuleStyles( $styles );
$out->addModuleScripts( 'mobile.usermodule' );
$out->addJsConfigVars( $this->getSkinConfigVariables() );
}
diff --git a/resources/skins.minerva.print.styles/styles.less
b/resources/skins.minerva.print.styles/styles.less
new file mode 100644
index 0000000..91e7cdc
--- /dev/null
+++ b/resources/skins.minerva.print.styles/styles.less
@@ -0,0 +1,2 @@
+@media print {
+}
\ No newline at end of file
--
To view, visit https://gerrit.wikimedia.org/r/343757
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic8b61b81c16a009721d635f133a72107d95b61d3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
