VolkerE has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/343775 )

Change subject: ButtonElement: Normalize appearance in Firefox
......................................................................

ButtonElement: Normalize appearance in Firefox

Normalizing `.oo-ui-buttonElement-button` appearance when
`<button>` or `<input type=button>` is used.

Change-Id: Iab830e1fe6317bf5d9a81d3b40e4e958d990c51a
---
M src/styles/elements/ButtonElement.less
M src/themes/mediawiki/elements.less
2 files changed, 6 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/75/343775/1

diff --git a/src/styles/elements/ButtonElement.less 
b/src/styles/elements/ButtonElement.less
index db2e2ea..5c5ac6f 100644
--- a/src/styles/elements/ButtonElement.less
+++ b/src/styles/elements/ButtonElement.less
@@ -15,6 +15,12 @@
                white-space: nowrap;
                .oo-ui-unselectable();
 
+               // Support Firefox: Normalize by making inner border 
transparent & by removing padding
+               &::-moz-focus-inner {
+                       border-color: transparent;
+                       padding: 0;
+               }
+
                > .oo-ui-iconElement-icon,
                > .oo-ui-indicatorElement-indicator {
                        display: none;
diff --git a/src/themes/mediawiki/elements.less 
b/src/themes/mediawiki/elements.less
index 26d2a0d..a59bc1d 100644
--- a/src/themes/mediawiki/elements.less
+++ b/src/themes/mediawiki/elements.less
@@ -10,11 +10,6 @@
                &:focus {
                        border-radius: @border-radius-default;
                        outline: 0;
-
-                       // Normalize: Make the inner border transparent in 
Firefox
-                       &::-moz-focus-inner {
-                               border-color: transparent;
-                       }
                }
        }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/343775
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iab830e1fe6317bf5d9a81d3b40e4e958d990c51a
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE <volke...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to