jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/344120 )
Change subject: Check for string initialization in ucfirst() to make HHVM 3.18
happy
......................................................................
Check for string initialization in ucfirst() to make HHVM 3.18 happy
Bug: T161095
Change-Id: I45b5d9e819061f443d4342c004bad80bd87c2a17
---
M languages/classes/LanguageAz.php
M languages/classes/LanguageKk.php
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
jenkins-bot: Verified
Nikerabbit: Checked; Looks good to me, approved
diff --git a/languages/classes/LanguageAz.php b/languages/classes/LanguageAz.php
index b413ef9..bd42a12 100644
--- a/languages/classes/LanguageAz.php
+++ b/languages/classes/LanguageAz.php
@@ -33,7 +33,7 @@
* @return mixed|string
*/
public function ucfirst( $string ) {
- if ( $string[0] == 'i' ) {
+ if ( substr( $string, 0, 1 ) === 'i' ) {
return 'İ' . substr( $string, 1 );
}
return parent::ucfirst( $string );
diff --git a/languages/classes/LanguageKk.php b/languages/classes/LanguageKk.php
index 3605e8d..0460a6c 100644
--- a/languages/classes/LanguageKk.php
+++ b/languages/classes/LanguageKk.php
@@ -391,7 +391,7 @@
* @return string
*/
public function ucfirst( $string ) {
- if ( $string[0] == 'i' ) {
+ if ( substr( $string, 0, 1 ) === 'i' ) {
$variant = $this->getPreferredVariant();
if ( $variant == 'kk-latn' || $variant == 'kk-tr' ) {
return 'İ' . substr( $string, 1 );
--
To view, visit https://gerrit.wikimedia.org/r/344120
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I45b5d9e819061f443d4342c004bad80bd87c2a17
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aklapper <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
