Awight has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/344189 )
Change subject: More cron syntax checks
......................................................................
More cron syntax checks
Change-Id: I956eae9ffea489c6a82703080ada89fe1826ddbe
---
M processcontrol/config.py
1 file changed, 7 insertions(+), 0 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/process-control
refs/changes/89/344189/1
diff --git a/processcontrol/config.py b/processcontrol/config.py
index 5854176..175997d 100644
--- a/processcontrol/config.py
+++ b/processcontrol/config.py
@@ -74,13 +74,20 @@
def validate_job_config(self):
assert "name" in self.values
+
assert "command" in self.values
+ assert "\n" not in self.values["command"]
+ # No incredibly stealthy line breaks.
+ assert "%" not in self.values["command"]
+
assert "stdout_destination" in self.values
if "schedule" in self.values:
# No tricky assignments.
assert "=" not in self.values["schedule"]
# Legal cron, but I don't want to deal with it.
assert "@" not in self.values["schedule"]
+ # No line breaks
+ assert "\n" not in self.values["schedule"]
# Be sure the schedule is valid.
terms = self.values["schedule"].split()
--
To view, visit https://gerrit.wikimedia.org/r/344189
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I956eae9ffea489c6a82703080ada89fe1826ddbe
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/process-control
Gerrit-Branch: master
Gerrit-Owner: Awight <awi...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
