Awight has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/344260 )
Change subject: Remove unused config inline defaults
......................................................................
Remove unused config inline defaults
Change-Id: Ice7437d238de683b6dc4bf1870bd03288cf77dc5
---
M processcontrol/config.py
1 file changed, 5 insertions(+), 8 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/process-control
refs/changes/60/344260/1
diff --git a/processcontrol/config.py b/processcontrol/config.py
index 5ffddff..47ef279 100644
--- a/processcontrol/config.py
+++ b/processcontrol/config.py
@@ -8,22 +8,19 @@
def __init__(self, defaults={}):
self.values = defaults
- def get(self, path, default=None):
+ def get(self, path):
"""Get a value from configuration.
You can get a nested property by using a path delimited by
- forward slashes (/).
- If you provide a default value, it will be used when the
- desired property does not exist. If there is no default,
- trying to get a missing property raises a MissingKeyException.
+ forward slashes (/), for example "failmail/from-address".
+
+ Trying to get a missing property raises a MissingKeyException.
"""
parts = path.split("/")
current = self.values
for part in parts:
if part not in current:
- if default is None:
- raise MissingKeyException(path)
- return default
+ raise MissingKeyException(path)
current = current[part]
return current
--
To view, visit https://gerrit.wikimedia.org/r/344260
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ice7437d238de683b6dc4bf1870bd03288cf77dc5
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/process-control
Gerrit-Branch: master
Gerrit-Owner: Awight <awi...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
