Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/344266 )
Change subject: Hygiene: remove ResponseLoggingInterceptor
......................................................................
Hygiene: remove ResponseLoggingInterceptor
In combination with HttpLoggingInterceptor, ResponseLoggingInterceptor
is too noisy. The ideal solution would be to extend
HttpLoggingInterceptor but the class is not very extensible.
Change-Id: I137c397af0f8634642b7ccf809018c32f154b2e0
---
M app/src/main/java/org/wikipedia/dataclient/okhttp/OkHttpConnectionFactory.java
D
app/src/main/java/org/wikipedia/dataclient/okhttp/ResponseLoggingInterceptor.java
2 files changed, 0 insertions(+), 41 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/66/344266/1
diff --git
a/app/src/main/java/org/wikipedia/dataclient/okhttp/OkHttpConnectionFactory.java
b/app/src/main/java/org/wikipedia/dataclient/okhttp/OkHttpConnectionFactory.java
index a4d34ea..91aea52 100644
---
a/app/src/main/java/org/wikipedia/dataclient/okhttp/OkHttpConnectionFactory.java
+++
b/app/src/main/java/org/wikipedia/dataclient/okhttp/OkHttpConnectionFactory.java
@@ -69,8 +69,6 @@
.addInterceptor(new CacheIfErrorInterceptor())
.addInterceptor(new
CacheDelegateInterceptor(CacheDelegate.internalCache(SAVE_CACHE),
CacheDelegate.internalCache(NET_CACHE)))
.addInterceptor(new
WikipediaZeroResponseInterceptor(WikipediaApp.getInstance().getWikipediaZeroHandler()))
- // this interceptor should appear last since it examines the
final cache and network responses
- .addInterceptor(new
ResponseLoggingInterceptor().setLevel(Prefs.getRetrofitLogLevel()))
.build();
}
}
diff --git
a/app/src/main/java/org/wikipedia/dataclient/okhttp/ResponseLoggingInterceptor.java
b/app/src/main/java/org/wikipedia/dataclient/okhttp/ResponseLoggingInterceptor.java
deleted file mode 100644
index 4e74498..0000000
---
a/app/src/main/java/org/wikipedia/dataclient/okhttp/ResponseLoggingInterceptor.java
+++ /dev/null
@@ -1,39 +0,0 @@
-package org.wikipedia.dataclient.okhttp;
-
-import android.support.annotation.NonNull;
-
-import org.wikipedia.util.log.L;
-
-import java.io.IOException;
-
-import okhttp3.Interceptor;
-import okhttp3.Response;
-import okhttp3.logging.HttpLoggingInterceptor;
-
-class ResponseLoggingInterceptor implements Interceptor {
- @NonNull private volatile HttpLoggingInterceptor.Level level =
HttpLoggingInterceptor.Level.NONE;
-
- public ResponseLoggingInterceptor setLevel(@NonNull
HttpLoggingInterceptor.Level level) {
- this.level = level;
- return this;
- }
-
- @Override public Response intercept(Chain chain) throws IOException {
- Response rsp = chain.proceed(chain.request());
-
- if (level == HttpLoggingInterceptor.Level.NONE) {
- return rsp;
- }
-
- StringBuilder builder = new
StringBuilder(rsp.request().url().toString());
- if (rsp.networkResponse() != null) {
- builder.append(" [net]");
- }
- if (rsp.cacheResponse() != null) {
- builder.append(" [cache]");
- }
- L.v(builder.toString());
-
- return rsp;
- }
-}
--
To view, visit https://gerrit.wikimedia.org/r/344266
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I137c397af0f8634642b7ccf809018c32f154b2e0
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: Sniedzielski <sniedziel...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
