Hello Pwirth, Robert Vogel, Mglaser, jenkins-bot,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/344346
to review the following change.
Change subject: Revert "BSReview: Fixed more notices"
......................................................................
Revert "BSReview: Fixed more notices"
This reverts commit 9948a96904ed9dcb45d8413d500abedc2cd10525.
Change-Id: I52358e9dc799306e430ab7b5d3c4159933278368
---
M Review/Review.class.php
1 file changed, 5 insertions(+), 5 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceExtensions
refs/changes/46/344346/1
diff --git a/Review/Review.class.php b/Review/Review.class.php
index 3a15e78..f182a46 100644
--- a/Review/Review.class.php
+++ b/Review/Review.class.php
@@ -160,7 +160,7 @@
);
}
- public static function onEchoGetDefaultNotifiedUsers( $event, &$users )
{
+ public function onEchoGetDefaultNotifiedUsers( $event, &$users ) {
switch ( $event->getType() ) {
case 'bs-review-assign':
$extra = $event->getExtra();
@@ -912,7 +912,7 @@
*
* @return boolean Always true to keep hook running
*/
- public static function onStateBarBeforeTopViewAdd( $oStateBar,
&$aTopViews, $oUser, $oTitle ) {
+ public function onStateBarBeforeTopViewAdd( $oStateBar, &$aTopViews,
$oUser, $oTitle ) {
$sIcon = 'bs-infobar-workflow-open';
$oRev = BsReviewProcess::newFromPid( $oTitle->getArticleID() );
if ( $oRev ) {
@@ -1019,7 +1019,7 @@
*
* @return boolean Always true to keep hook running
*/
- public static function onStateBarBeforeBodyViewAdd( $oStateBar,
&$aBodyViews, $oUser, $oTitle ) {
+ public function onStateBarBeforeBodyViewAdd( $oStateBar, &$aBodyViews,
$oUser, $oTitle ) {
$text = '';
$oRev = BsReviewProcess::newFromPid( $oTitle->getArticleID() );
$pages = BsReviewProcess::listReviews( $oUser->getId() );
@@ -1146,7 +1146,7 @@
* @param string $sWidgetTitle
* @return boolean
*/
- public static function onBSUserSidebarGlobalActionsWidgetGlobalActions(
UserSidebar $oUserSidebar, User $oUser, &$aLinks, &$sWidgetTitle ) {
+ public function onBSUserSidebarGlobalActionsWidgetGlobalActions(
UserSidebar $oUserSidebar, User $oUser, &$aLinks, &$sWidgetTitle ) {
$oSpecialReview = SpecialPageFactory::getPage( 'Review' );
if( !$oSpecialReview ) {
return true;
@@ -1172,7 +1172,7 @@
*
* @return boolean Always true to keep hook running
*/
- public static function onSkinTemplateOutputPageBeforeExec(
&$sktemplate, &$tpl ) {
+ public function onSkinTemplateOutputPageBeforeExec( &$sktemplate, &$tpl
) {
$oUser = $sktemplate->getUser();
if ( $oUser->isAllowed( 'workflowview' ) === false ) {
return true;
--
To view, visit https://gerrit.wikimedia.org/r/344346
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I52358e9dc799306e430ab7b5d3c4159933278368
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions
Gerrit-Branch: master
Gerrit-Owner: Ljonka <[email protected]>
Gerrit-Reviewer: Mglaser <[email protected]>
Gerrit-Reviewer: Pwirth <[email protected]>
Gerrit-Reviewer: Robert Vogel <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
