Hello Pwirth, Robert Vogel, Mglaser, jenkins-bot,

I'd like you to do a code review.  Please visit

    https://gerrit.wikimedia.org/r/344350

to review the following change.


Change subject: Revert "BSReview: Fixed notices" to merge other commits first 
without merge conflict
......................................................................

Revert "BSReview: Fixed notices" to merge other commits first without merge 
conflict

This reverts commit dd8b0bc9b26d8f133d44928d5d371b497c9e940d.

Change-Id: I3758264b3a535bde45a78db07d6abf8378b2a79c
---
M Review/Review.class.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceExtensions 
refs/changes/50/344350/1

diff --git a/Review/Review.class.php b/Review/Review.class.php
index 8ea2cd3..17d3cef 100644
--- a/Review/Review.class.php
+++ b/Review/Review.class.php
@@ -399,7 +399,7 @@
         *
         * @return boolean Always true to keep hook running
         */
-       public static function onStatebarAddSortTopVars( &$aSortTopVars ) {
+       public function onStatebarAddSortTopVars( &$aSortTopVars ) {
                $aSortTopVars[ 'statebartopreview' ] = wfMessage( 
'bs-review-review' )->plain();
 
                return true;
@@ -412,7 +412,7 @@
         *
         * @return boolean Always true to keep hook running
         */
-       public static function onStatebarAddSortBodyVars( &$aSortBodyVars ) {
+       public function onStatebarAddSortBodyVars( &$aSortBodyVars ) {
                $aSortBodyVars[ 'statebarbodyreview' ] = wfMessage( 
'bs-review-review' )->plain();
 
                return true;

-- 
To view, visit https://gerrit.wikimedia.org/r/344350
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3758264b3a535bde45a78db07d6abf8378b2a79c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions
Gerrit-Branch: REL1_27
Gerrit-Owner: Ljonka <[email protected]>
Gerrit-Reviewer: Mglaser <[email protected]>
Gerrit-Reviewer: Pwirth <[email protected]>
Gerrit-Reviewer: Robert Vogel <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to