Santhosh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/51178


Change subject: (bug 45488) Remove delay in enablement of "save translation" 
button
......................................................................

(bug 45488) Remove delay in enablement of "save translation" button

Change-Id: I47bb99c978a5ae522a524f8126944736075aed88
---
M resources/js/ext.translate.editor.js
1 file changed, 13 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/78/51178/1

diff --git a/resources/js/ext.translate.editor.js 
b/resources/js/ext.translate.editor.js
index ca59de1..75ae71e 100644
--- a/resources/js/ext.translate.editor.js
+++ b/resources/js/ext.translate.editor.js
@@ -330,23 +330,22 @@
                                } );
 
                        $textArea.on( 'input propertychange', function () {
-                               var $textArea = $( this );
+                               var $textArea = $( this ),
+                                       $saveButton = 
translateEditor.$editor.find( '.tux-editor-save-button' ),
+                                       $pasteSourceButton = 
translateEditor.$editor.find( '.tux-editor-paste-original-button' );
+
+                               $saveButton.text( mw.msg( 
'tux-editor-save-button-label' ) );
+                               // When there is content in the editor
+                               if ( $.trim( $textArea.val() ) ) {
+                                       $pasteSourceButton.addClass( 'hide' );
+                                       $saveButton.prop( 'disabled', false );
+                               } else {
+                                       $saveButton.prop( 'disabled', true );
+                                       $pasteSourceButton.removeClass( 'hide' 
);
+                               }
 
                                delay( function () {
-                                       var $saveButton = 
translateEditor.$editor.find( '.tux-editor-save-button' ),
-                                               $pasteSourceButton = 
translateEditor.$editor.find( '.tux-editor-paste-original-button' );
-
                                        translateEditor.validateTranslation();
-                                       $saveButton.text( mw.msg( 
'tux-editor-save-button-label' ) );
-
-                                       // When there is content in the editor
-                                       if ( $.trim( $textArea.val() ) ) {
-                                               $pasteSourceButton.addClass( 
'hide' );
-                                               $saveButton.prop( 'disabled', 
false );
-                                       } else {
-                                               $saveButton.prop( 'disabled', 
true );
-                                               $pasteSourceButton.removeClass( 
'hide' );
-                                       }
                                }, 500 );
                        } );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/51178
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I47bb99c978a5ae522a524f8126944736075aed88
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Santhosh <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to