Awight has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/344501 )

Change subject: Test for environment parameter
......................................................................

Test for environment parameter

Change-Id: I7739f28ca9fd3b11754a5eae0c10ee59a034d384
---
A tests/data/env.yaml
M tests/test_job_wrapper.py
2 files changed, 28 insertions(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/process-control 
refs/changes/01/344501/1

diff --git a/tests/data/env.yaml b/tests/data/env.yaml
new file mode 100644
index 0000000..bdc5ef3
--- /dev/null
+++ b/tests/data/env.yaml
@@ -0,0 +1,5 @@
+name: Env dumper
+command: /usr/bin/env
+environment:
+    foo1: bar
+    foo2: rebar
diff --git a/tests/test_job_wrapper.py b/tests/test_job_wrapper.py
index f95480c..ef290d5 100644
--- a/tests/test_job_wrapper.py
+++ b/tests/test_job_wrapper.py
@@ -79,7 +79,6 @@
     run_job("which_out.yaml")
 
     log_files = sorted(glob.glob(path_glob))
-    assert len(log_files) == 1
     path = log_files[-1]
     contents = open(path, "r").read()
     lines = contents.split("\n")
@@ -88,3 +87,26 @@
     assert lines[4] == "/bin/bash"
 
     os.unlink(path)
+
+
+def test_environment():
+    path_glob = "/tmp/Env dumper/Env dumper*.log"
+
+    run_job("env.yaml")
+
+    log_files = sorted(glob.glob(path_glob))
+    path = log_files[-1]
+    contents = open(path, "r").read()
+    lines = contents.split("\n")
+    print(lines)
+
+    assert len(lines) == 7
+
+    dumped_env = sorted(lines[4:6])
+    expected = [
+        "foo1=bar",
+        "foo2=rebar",
+    ]
+    assert expected == dumped_env
+
+    os.unlink(path)

-- 
To view, visit https://gerrit.wikimedia.org/r/344501
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7739f28ca9fd3b11754a5eae0c10ee59a034d384
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/process-control
Gerrit-Branch: master
Gerrit-Owner: Awight <awi...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to