Mholloway has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344546 )
Change subject: Mark up missing links in Parsoid article HTML ...................................................................... Mark up missing links in Parsoid article HTML Rather than adding another round of expensive content-munging in the DOM, just mark up anchors for missing links with an additional 'new' class (as is found in MediaWiki HTML) and let clients handle them as they wish. In the Android app, for instance, this means we can just go back to using the client-side hideRedLinks transform for all HTML sources. Hopefully, this will perform better than the previous two iterations of this patch, and will not need reverting yet again! This reverts commit cbc50dd0980eb27ca21beb0148d920855b3d37f9. Bug: T119266 Change-Id: Ia912be4912d194d67fc6bd11af1ecfe9b4814e48 --- M lib/mwapi.js M lib/parsoid-access.js D lib/transformations/hideRedLinks.js A lib/transformations/markParsoidMissingLinks.js M lib/transforms.js M test/diff/results/page_formatted-dewiki-Helium.json M test/diff/results/page_formatted-dewiki-Helium/lead-intro.html M test/diff/results/page_formatted-dewiki-Helium/lead-text.html M test/diff/results/page_formatted-dewiki-Helium/section1-text.html M test/diff/results/page_formatted-dewiki-Helium/section10-text.html M test/diff/results/page_formatted-dewiki-Helium/section13-text.html M test/diff/results/page_formatted-dewiki-Helium/section14-text.html M test/diff/results/page_formatted-dewiki-Helium/section15-text.html M test/diff/results/page_formatted-dewiki-Helium/section17-text.html M test/diff/results/page_formatted-dewiki-Helium/section20-text.html M test/diff/results/page_formatted-dewiki-Helium/section22-text.html M test/diff/results/page_formatted-dewiki-Helium/section26-text.html M test/diff/results/page_formatted-dewiki-Helium/section28-text.html M test/diff/results/page_formatted-dewiki-Helium/section3-text.html M test/diff/results/page_formatted-dewiki-Helium/section5-text.html M test/diff/results/page_formatted-dewiki-Helium/section6-text.html M test/diff/results/page_formatted-dewiki-Helium/section9-text.html M test/diff/results/page_formatted-enwiki-8_mm/lead-text.html M test/diff/results/page_formatted-hewiki-%D7%90%D7%91%D7%99%D7%A8.json M test/diff/results/page_formatted-hewiki-%D7%90%D7%91%D7%99%D7%A8/lead-intro.html M test/diff/results/page_formatted-hewiki-%D7%90%D7%91%D7%99%D7%A8/lead-text.html M test/diff/results/page_formatted-hewiki-%D7%90%D7%91%D7%99%D7%A8/section3-text.html M test/diff/results/page_formatted-hewiki-%D7%90%D7%91%D7%99%D7%A8/section4-text.html M test/diff/results/page_formatted-hewiki-%D7%90%D7%91%D7%99%D7%A8/section5-text.html M test/diff/results/page_formatted-hewiki-%D7%90%D7%91%D7%99%D7%A8/section7-text.html M test/diff/results/page_formatted-hewiki-%D7%90%D7%91%D7%99%D7%A8/section8-text.html M test/diff/results/page_formatted-itwiki-Pittore.json M test/diff/results/page_formatted-itwiki-Pittore/lead-intro.html M test/diff/results/page_formatted-itwiki-Pittore/lead-text.html M test/diff/results/page_formatted-itwiki-Pittore/section1-text.html M test/diff/results/page_mobile-sections-dewiki-Helium.json M test/diff/results/page_mobile-sections-dewiki-Helium/lead-section0-text.html M test/diff/results/page_mobile-sections-dewiki-Helium/section1-text.html M test/diff/results/page_mobile-sections-dewiki-Helium/section10-text.html M test/diff/results/page_mobile-sections-dewiki-Helium/section13-text.html M test/diff/results/page_mobile-sections-dewiki-Helium/section14-text.html M test/diff/results/page_mobile-sections-dewiki-Helium/section15-text.html M test/diff/results/page_mobile-sections-dewiki-Helium/section17-text.html M test/diff/results/page_mobile-sections-dewiki-Helium/section20-text.html M test/diff/results/page_mobile-sections-dewiki-Helium/section22-text.html M test/diff/results/page_mobile-sections-dewiki-Helium/section26-text.html M test/diff/results/page_mobile-sections-dewiki-Helium/section28-text.html M test/diff/results/page_mobile-sections-dewiki-Helium/section3-text.html M test/diff/results/page_mobile-sections-dewiki-Helium/section5-text.html M test/diff/results/page_mobile-sections-dewiki-Helium/section6-text.html M test/diff/results/page_mobile-sections-dewiki-Helium/section9-text.html M test/diff/results/page_mobile-sections-enwiki-8_mm/lead-section0-text.html M test/diff/results/page_mobile-sections-hewiki-%D7%90%D7%91%D7%99%D7%A8.json M test/diff/results/page_mobile-sections-hewiki-%D7%90%D7%91%D7%99%D7%A8/lead-section0-text.html M test/diff/results/page_mobile-sections-hewiki-%D7%90%D7%91%D7%99%D7%A8/section3-text.html M test/diff/results/page_mobile-sections-hewiki-%D7%90%D7%91%D7%99%D7%A8/section4-text.html M test/diff/results/page_mobile-sections-hewiki-%D7%90%D7%91%D7%99%D7%A8/section5-text.html M test/diff/results/page_mobile-sections-hewiki-%D7%90%D7%91%D7%99%D7%A8/section7-text.html M test/diff/results/page_mobile-sections-hewiki-%D7%90%D7%91%D7%99%D7%A8/section8-text.html M test/diff/results/page_mobile-sections-itwiki-Pittore.json M test/diff/results/page_mobile-sections-itwiki-Pittore/lead-section0-text.html M test/diff/results/page_mobile-sections-itwiki-Pittore/section1-text.html M test/features/mobile-sections/pagecontent.js 63 files changed, 509 insertions(+), 547 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps refs/changes/46/344546/1 -- To view, visit https://gerrit.wikimedia.org/r/344546 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia912be4912d194d67fc6bd11af1ecfe9b4814e48 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/services/mobileapps Gerrit-Branch: master Gerrit-Owner: Mholloway <mhollo...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
