Awight has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/344552 )
Change subject: [HOTFIX] Patch orphan rectifier to drop non-cc records
......................................................................
[HOTFIX] Patch orphan rectifier to drop non-cc records
NOTE: Directly patched to avoid composer churn during code freeze.
Bug: T161160
Change-Id: Ia6fe7626ea21867055bb147ceef1e00c33c907bf
---
M
wikimedia/donation-interface/globalcollect_gateway/GlobalCollectOrphanRectifier.php
1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm/vendor
refs/changes/52/344552/1
diff --git
a/wikimedia/donation-interface/globalcollect_gateway/GlobalCollectOrphanRectifier.php
b/wikimedia/donation-interface/globalcollect_gateway/GlobalCollectOrphanRectifier.php
index ac404b1..6d44465 100644
---
a/wikimedia/donation-interface/globalcollect_gateway/GlobalCollectOrphanRectifier.php
+++
b/wikimedia/donation-interface/globalcollect_gateway/GlobalCollectOrphanRectifier.php
@@ -160,6 +160,13 @@
* @return boolean True if the orphan has been rectified, false if not.
*/
protected function rectifyOrphan( $normalized ){
+ if ( $normalized['payment_method'] !== 'cc' ) {
+ // Skip other payment methods which shouldn't be in the
pending
+ // queue anyway. See
https://phabricator.wikimedia.org/T161160
+ $this->logger->info( "Skipping non-credit card pending
record." );
+ return false;
+ }
+
$this->logger->info( "Rectifying orphan:
{$normalized['order_id']}" );
$is_rectified = false;
--
To view, visit https://gerrit.wikimedia.org/r/344552
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia6fe7626ea21867055bb147ceef1e00c33c907bf
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/crm/vendor
Gerrit-Branch: master
Gerrit-Owner: Awight <awi...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
