jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/344686 )
Change subject: Minor cleanup and comments on issues found by eslint
......................................................................
Minor cleanup and comments on issues found by eslint
Bug: T161142
Change-Id: Ia6867d2f4142b0c9b529679b5282e903abf8516c
---
M resources/infrastructure/ext.centralNotice.adminUi.campaignPager.js
M resources/subscribing/ext.centralNotice.bannerHistoryLogger.js
M resources/subscribing/ext.centralNotice.largeBannerLimit.js
3 files changed, 3 insertions(+), 2 deletions(-)
Approvals:
jenkins-bot: Verified
Ejegg: Looks good to me, approved
diff --git
a/resources/infrastructure/ext.centralNotice.adminUi.campaignPager.js
b/resources/infrastructure/ext.centralNotice.adminUi.campaignPager.js
index 92a5ad5..b78a36a 100644
--- a/resources/infrastructure/ext.centralNotice.adminUi.campaignPager.js
+++ b/resources/infrastructure/ext.centralNotice.adminUi.campaignPager.js
@@ -2,6 +2,7 @@
* CentralNotice Administrative UI - Campaign pager
*/
/* eslint-disable no-unused-vars */
+// TODO Check whether we can use Object.keys() now, to remove the unused k var
and above rule.
( function ( mw, $ ) {
var changes = {};
diff --git a/resources/subscribing/ext.centralNotice.bannerHistoryLogger.js
b/resources/subscribing/ext.centralNotice.bannerHistoryLogger.js
index 5f3c9ae..0f1925d 100644
--- a/resources/subscribing/ext.centralNotice.bannerHistoryLogger.js
+++ b/resources/subscribing/ext.centralNotice.bannerHistoryLogger.js
@@ -1,4 +1,5 @@
/* eslint-disable no-unused-vars */
+// TODO Remove above directive once inSample var is used.
/*
* Banner history logger mixin. Records an event every time this campaign is
* selected for the user (even if the banner is hidden). The log is kept in
diff --git a/resources/subscribing/ext.centralNotice.largeBannerLimit.js
b/resources/subscribing/ext.centralNotice.largeBannerLimit.js
index 75ee0cf..91d1f60 100644
--- a/resources/subscribing/ext.centralNotice.largeBannerLimit.js
+++ b/resources/subscribing/ext.centralNotice.largeBannerLimit.js
@@ -9,7 +9,6 @@
*
https://meta.wikimedia.org/wiki/MediaWiki:FR2014/Resources/ShowHideCheckFullscreen.js
*
https://meta.wikimedia.org/wiki/MediaWiki:FR2014/Resources/ChangeBucket-AtoC-BtoD.js
*/
-/* eslint-disable no-unused-vars */
( function ( mw ) {
'use strict';
@@ -145,7 +144,7 @@
// gets shown, and set a flag, in the post banner handler.
} );
- mixin.setPostBannerHandler( function ( mixinParams ) {
+ mixin.setPostBannerHandler( function () {
// If a large banner was shown, but not forced, set a flag to
remember
// the reader has seen a large banner. The next time they might
--
To view, visit https://gerrit.wikimedia.org/r/344686
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6867d2f4142b0c9b529679b5282e903abf8516c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: AndyRussG <[email protected]>
Gerrit-Reviewer: Awight <[email protected]>
Gerrit-Reviewer: Cdentinger <[email protected]>
Gerrit-Reviewer: Ejegg <[email protected]>
Gerrit-Reviewer: Ssmith <[email protected]>
Gerrit-Reviewer: XenoRyet <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
