jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/344682 )
Change subject: Use ve.targetLinksToNewWindow
......................................................................
Use ve.targetLinksToNewWindow
Depends-On: I3088e8b95d9032b8e8fd5bff58a8b97ffaa15f98
Change-Id: I07ec10841b62ed1e8c3b3cf82b42653327618cb0
---
M modules/ve-mw/init/ve.init.mw.ArticleTarget.js
1 file changed, 2 insertions(+), 5 deletions(-)
Approvals:
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
b/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
index d9394ba..73ff1aa 100644
--- a/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
+++ b/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
@@ -376,7 +376,7 @@
}
if ( $label ) {
title = $label.attr( 'title' );
- $label.find( 'a' ).attr( 'target', '_blank' );
+ ve.targetLinksToNewWindow( $label[ 0 ] );
}
checkbox = new OO.ui.CheckboxInputWidget( {
value: $this.attr( 'value' ),
@@ -1116,10 +1116,7 @@
document.adoptNode( body );
// TODO: This code is very similar to
ve.ui.PreviewElement
ve.resolveAttributes( body, doc,
ve.dm.Converter.static.computedAttributes );
- // Make all links open in a new window (sync
view)
- Array.prototype.forEach.call(
body.querySelectorAll( 'a[href]' ), function ( el ) {
- el.setAttribute( 'target', '_blank' );
- } );
+ ve.targetLinksToNewWindow( body );
target.saveDialog.showPreview( $( body
).contents() );
} else {
target.saveDialog.showPreview( $( '<em>' ).text(
--
To view, visit https://gerrit.wikimedia.org/r/344682
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I07ec10841b62ed1e8c3b3cf82b42653327618cb0
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
