Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/344733 )
Change subject: mediawiki-core-code-coverage: Commit live hack
......................................................................
mediawiki-core-code-coverage: Commit live hack
Follows-up 4c65c6e4 which made it so that the report is never published
because we actually have a few PHPUnit tests that normally pass but
fail when --coverage-html is enabled because it is so slow that
certain assumptions about time and clock are wrong.
(T161041, T160956, ..). These have been around for a while and
are harmless for now. Shouldn't stop us from publishing the report.
Ignore exit code, but still guard against publishing an empty directory
in case of segfaults and other fatal errors, so simply check if
index.html was created (which is the last thing before exit).
Change-Id: I2df4cbc5eb459852a83ee048f5e7d90a3aa1c789
---
M jjb/mediawiki.yaml
1 file changed, 13 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/integration/config
refs/changes/33/344733/1
diff --git a/jjb/mediawiki.yaml b/jjb/mediawiki.yaml
index ee6e5a2..d75c6d6 100644
--- a/jjb/mediawiki.yaml
+++ b/jjb/mediawiki.yaml
@@ -336,7 +336,19 @@
nice -n 19 php $MW_INSTALL_PATH/tests/phpunit/phpunit.php \
--exclude-group Dump,Broken,ParserFuzz,Stub \
--coverage-clover log/clover.xml \
- --coverage-html "$WORKSPACE/cover"
+ --coverage-html "$WORKSPACE/cover" \
+ || :
+ # Above: Use "|| :" to ignore any non-zero exist status
+ # We want to publish code coverage even in case one of there
+ # being PHPUnit test failures. Normal test failures are not
+ # fatal and PHPUnit will stil generate console output, clover
+ # reports and and html reports. However don't blindly
+ # make the job pass either because if we do, then cover-publish
+ # will end up syncing an empty directory, which deletes the
+ # coverage report from doc.wikimedia.org. In case of "real" failure,
+ # let the job fail and don't publish a new report. "real" failures
+ # can be a PHP Fatal error, of a segfault, for example.
+ test -f cover/index.html
- cover-publish:
src: 'cover'
--
To view, visit https://gerrit.wikimedia.org/r/344733
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2df4cbc5eb459852a83ee048f5e7d90a3aa1c789
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
