Ladsgroup has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/344751 )

Change subject: Throw RuntimeException when caching doesn't work in 
testDispatchCoordinator
......................................................................

Throw RuntimeException when caching doesn't work in testDispatchCoordinator

Bug: T157308
Change-Id: If179be912f3b5de680533abf9ba618d6ca4fb1b3
---
M repo/tests/testDispatchCoordinator.php
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/51/344751/1

diff --git a/repo/tests/testDispatchCoordinator.php 
b/repo/tests/testDispatchCoordinator.php
index 4047f1e..3276c17 100644
--- a/repo/tests/testDispatchCoordinator.php
+++ b/repo/tests/testDispatchCoordinator.php
@@ -7,6 +7,7 @@
 use Maintenance;
 use MediaWiki\MediaWikiServices;
 use MWException;
+use RuntimeException;
 use WANObjectCache;
 use Wikibase\Repo\Store\Sql\LockManagerSqlChangeDispatchCoordinator;
 use Wikibase\Repo\WikibaseRepo;
@@ -179,6 +180,10 @@
        }
 
        private function assertSame( $expected, $actual ) {
+               if ( $actual === null ) {
+                       throw new RuntimeException( "Caching mechanism doesn't 
work as expected." );
+               }
+
                if ( $expected !== $actual ) {
                        throw new LogicException( "Test failed: $actual is not 
the same as expected $expected" );
                }

-- 
To view, visit https://gerrit.wikimedia.org/r/344751
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If179be912f3b5de680533abf9ba618d6ca4fb1b3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Ladsgroup <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to