Seb35 has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/344784 )
Change subject: Restore 100% code coverage
......................................................................
Restore 100% code coverage
Change-Id: I0adbef2d9113679b4793b41beb7a92621db198cc
---
M src/MediaWikiFarmComposerScript.php
M tests/phpunit/data/mediawiki/vstub/composer.json
2 files changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MediaWikiFarm
refs/changes/84/344784/1
diff --git a/src/MediaWikiFarmComposerScript.php
b/src/MediaWikiFarmComposerScript.php
index 42fd69e..93caaab 100644
--- a/src/MediaWikiFarmComposerScript.php
+++ b/src/MediaWikiFarmComposerScript.php
@@ -149,7 +149,7 @@
unset(
$baseComposerJson['require'][$package['name']] );
}
if( array_key_exists( 'require-dev',
$baseComposerJson ) && array_key_exists( $package['name'],
$baseComposerJson['require-dev'] ) ) {
- unset(
$baseComposerJson['require-dev'][$package['name']] ); // @codeCoverageIgnore
+ unset(
$baseComposerJson['require-dev'][$package['name']] );
}
$dependencies[$extensions[$package['name']]] =
array_key_exists( 'require', $package ) ? array_keys( $package['require'] ) :
array();
}
diff --git a/tests/phpunit/data/mediawiki/vstub/composer.json
b/tests/phpunit/data/mediawiki/vstub/composer.json
index c3746c3..2b88fcb 100644
--- a/tests/phpunit/data/mediawiki/vstub/composer.json
+++ b/tests/phpunit/data/mediawiki/vstub/composer.json
@@ -4,5 +4,8 @@
"mediawiki/page-forms": "*",
"mediawiki/semantic-forms-select": "*",
"mediawiki/chameleon-skin": "*"
+ },
+ "require-dev": {
+ "mediawiki/page-forms": "*"
}
}
--
To view, visit https://gerrit.wikimedia.org/r/344784
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0adbef2d9113679b4793b41beb7a92621db198cc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MediaWikiFarm
Gerrit-Branch: master
Gerrit-Owner: Seb35 <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
