Kelson has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/296548 )
Change subject: Use explicit LZMA_STREAM_INIT initializer, instead of memset.
......................................................................
Use explicit LZMA_STREAM_INIT initializer, instead of memset.
This follows the recommendations in lzma.h.
Change-Id: Ib6b392ba3c6a249fa55b8cf8c04cdae1ae407925
---
M zimlib/src/lzmastream.cpp
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Kelson: Verified; Looks good to me, approved
diff --git a/zimlib/src/lzmastream.cpp b/zimlib/src/lzmastream.cpp
index d880933..bd02bd8 100644
--- a/zimlib/src/lzmastream.cpp
+++ b/zimlib/src/lzmastream.cpp
@@ -58,11 +58,10 @@
}
LzmaStreamBuf::LzmaStreamBuf(std::streambuf* sink_, uint32_t preset,
lzma_check check, unsigned bufsize_)
- : obuffer(bufsize_),
+ : stream(LZMA_STREAM_INIT),
+ obuffer(bufsize_),
sink(sink_)
{
- std::memset(reinterpret_cast<void*>(&stream), 0, sizeof(stream));
-
checkError(
::lzma_easy_encoder(&stream, preset, check));
--
To view, visit https://gerrit.wikimedia.org/r/296548
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6b392ba3c6a249fa55b8cf8c04cdae1ae407925
Gerrit-PatchSet: 3
Gerrit-Project: openzim
Gerrit-Branch: master
Gerrit-Owner: C. Scott Ananian <canan...@wikimedia.org>
Gerrit-Reviewer: Kelson <kel...@kiwix.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
