jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/344123 )
Change subject: Only give code mirror focus for specific commands
......................................................................
Only give code mirror focus for specific commands
Previously focus was being called even for getContents, causing the
editor to instantly steal focus from the edit summary input (!!).
Change-Id: I5a14850d90a7c5605026e1fac192585ee62b4615
---
M resources/ext.CodeMirror.js
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
Kaldari: Looks good to me, approved
diff --git a/resources/ext.CodeMirror.js b/resources/ext.CodeMirror.js
index 9c4a9df..95f0234 100644
--- a/resources/ext.CodeMirror.js
+++ b/resources/ext.CodeMirror.js
@@ -227,7 +227,9 @@
}
retval = fn[ command ].call( this, options );
- codeMirror.focus();
+ if ( command === 'setSelection' ) {
+ codeMirror.focus();
+ }
return retval;
}
--
To view, visit https://gerrit.wikimedia.org/r/344123
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5a14850d90a7c5605026e1fac192585ee62b4615
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CodeMirror
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Kaldari <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
