Mforns has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/344914 )

Change subject: Fix domain_abbrev_map job to disambiguate wikimedia projects
......................................................................

Fix domain_abbrev_map job to disambiguate wikimedia projects

This script was generating ambiguous records for <lang>.wikimedia
projects. For example: dbname = arwikimedia, for which was
generating ar.m, which is the same as arwiki for mobile site.
Hence the resulting map table was not deterministic and wrong.
The documentation in
https://wikitech.wikimedia.org/wiki/Analytics/Data/Pagecounts-all-sites
makes it clear that the .m suffix for xyz.wikimedia sites is only
considered for the following wikis:
commons.wikimedia.org
meta.wikimedia.org
incubator.wikimedia.org
species.wikimedia.org
strategy.wikimedia.org
outreach.wikimedia.org
usability.wikimedia.org
quality.wikimedia.org
SO, this change removes all <lang>.wikimedia.org from the table
because they are not considered (and hence irrepresentable) by the
webstatscollector abbreviation system.

Bug: T156388
Change-Id: I041f5463de24d5c250c176af684ece11ed65b533
---
M bin/generate-abbreviation-domain-map
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/analytics/refinery 
refs/changes/14/344914/1

diff --git a/bin/generate-abbreviation-domain-map 
b/bin/generate-abbreviation-domain-map
index 60c8798..ed42f35 100755
--- a/bin/generate-abbreviation-domain-map
+++ b/bin/generate-abbreviation-domain-map
@@ -108,7 +108,11 @@
     return [
         wiki
         for wiki in wikis
-        if 'private' not in wiki
+        if (
+            'private' not in wiki and
+            'dbname' in wiki and
+            not wiki['dbname'].endswith('wikimedia')
+        )
     ]
 
 def dbname_to_webstatscollector_abbreviation(dbname, site='desktop'):

-- 
To view, visit https://gerrit.wikimedia.org/r/344914
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I041f5463de24d5c250c176af684ece11ed65b533
Gerrit-PatchSet: 1
Gerrit-Project: analytics/refinery
Gerrit-Branch: master
Gerrit-Owner: Mforns <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to