Mobrovac has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/344975 )
Change subject: Config: Do not use the proxy at all
......................................................................
Config: Do not use the proxy at all
The Mobile Content Service contacts only internal services, so it
doesn't need access to the proxy at all. Moreover, removing the proxy
secures us from having malicious requests to the external world that
shouldn't happen in the first place.
Bug: T97530
Change-Id: Ie1a0971b79d3abe350cbf4e09153288feb514c07
---
M scap/templates/config.yaml.j2
1 file changed, 5 insertions(+), 5 deletions(-)
Approvals:
Mobrovac: Verified; Looks good to me, approved
diff --git a/scap/templates/config.yaml.j2 b/scap/templates/config.yaml.j2
index 27ca03d..37e7138 100644
--- a/scap/templates/config.yaml.j2
+++ b/scap/templates/config.yaml.j2
@@ -50,12 +50,12 @@
# content for the CSP headers
# csp: false # uncomment this line to disable sending them
# URL of the outbound proxy to use (complete with protocol)
- proxy: <%= proxy if proxy else '' %>
+ # proxy: <%= proxy if proxy else '' %>
# the list of domains for which not to use the proxy defined above
- no_proxy_list:
- - eqiad.wmnet
- - codfw.wmnet
- - discovery.wmnet
+ # no_proxy_list:
+ # - eqiad.wmnet
+ # - codfw.wmnet
+ # - discovery.wmnet
# the list of incoming request headers that can be logged; if left empty,
# the following headers are allowed: cache-control, content-length,
# content-type, if-match, user-agent, x-request-id
--
To view, visit https://gerrit.wikimedia.org/r/344975
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie1a0971b79d3abe350cbf4e09153288feb514c07
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac <[email protected]>
Gerrit-Reviewer: BearND <[email protected]>
Gerrit-Reviewer: Giuseppe Lavagetto <[email protected]>
Gerrit-Reviewer: Mholloway <[email protected]>
Gerrit-Reviewer: Mobrovac <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
