jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/341307 )
Change subject: Add array typehint to 2 DatabaseUpdater methods
......................................................................
Add array typehint to 2 DatabaseUpdater methods
Change-Id: I29abd4525b46e9b47cf3933e5fcb791fd6ea3fb5
---
M includes/installer/DatabaseUpdater.php
M includes/installer/OracleUpdater.php
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Florianschmidtwelzow: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/installer/DatabaseUpdater.php
b/includes/installer/DatabaseUpdater.php
index f8ab1f2..98d354c 100644
--- a/includes/installer/DatabaseUpdater.php
+++ b/includes/installer/DatabaseUpdater.php
@@ -392,7 +392,7 @@
* Writes the schema updates desired to a file for the DB Admin to run.
* @param array $schemaUpdate
*/
- private function writeSchemaUpdateFile( $schemaUpdate = [] ) {
+ private function writeSchemaUpdateFile( array $schemaUpdate = [] ) {
$updates = $this->updatesSkipped;
$this->updatesSkipped = [];
@@ -425,7 +425,7 @@
*
* @param array $what What updates to perform
*/
- public function doUpdates( $what = [ 'core', 'extensions', 'stats' ] ) {
+ public function doUpdates( array $what = [ 'core', 'extensions',
'stats' ] ) {
$this->db->setSchemaVars( $this->getSchemaVars() );
$what = array_flip( $what );
diff --git a/includes/installer/OracleUpdater.php
b/includes/installer/OracleUpdater.php
index 79ae175..e262eda 100644
--- a/includes/installer/OracleUpdater.php
+++ b/includes/installer/OracleUpdater.php
@@ -285,7 +285,7 @@
*
* @param array $what
*/
- public function doUpdates( $what = [ 'core', 'extensions', 'purge',
'stats' ] ) {
+ public function doUpdates( array $what = [ 'core', 'extensions',
'purge', 'stats' ] ) {
parent::doUpdates( $what );
$this->db->query( 'BEGIN fill_wiki_info; END;' );
--
To view, visit https://gerrit.wikimedia.org/r/341307
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I29abd4525b46e9b47cf3933e5fcb791fd6ea3fb5
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
Gerrit-Reviewer: Florianschmidtwelzow <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
