jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/344994 )
Change subject: rcfilters: Avoid $.type()
......................................................................
rcfilters: Avoid $.type()
Followup to I9a0c5e40b813e075ec33eea882b625dc43a15df6
Replace $.type() with typeof or Array.isArray
Change-Id: I4f0f717c345ab1279b626b158b0ed6ada056bbc1
---
M resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
index 14eabe2..7405bae 100644
--- a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
+++ b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
@@ -321,8 +321,8 @@
* @param {array|object|string} filters
*/
mw.rcfilters.Controller.prototype.trackHighlight = function ( action,
filters ) {
- filters = $.type( filters ) === 'string' ? { name: filters } :
filters;
- filters = $.type( filters ) === 'object' ? [ filters ] :
filters;
+ filters = typeof filters === 'string' ? { name: filters } :
filters;
+ filters = !Array.isArray( filters ) ? [ filters ] : filters;
mw.track(
'event.ChangesListHighlights',
{
--
To view, visit https://gerrit.wikimedia.org/r/344994
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4f0f717c345ab1279b626b158b0ed6ada056bbc1
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Sbisson <[email protected]>
Gerrit-Reviewer: Jack Phoenix <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
