Ottomata has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/342913 )

Change subject: Fix improper index access in event logging code
......................................................................


Fix improper index access in event logging code

Bug: T115119
Change-Id: I8ebfb7dc9e513aa949cfc287d1a68b23f69d2784
---
M SpamBlacklist_body.php
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Ottomata: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/SpamBlacklist_body.php b/SpamBlacklist_body.php
index a72970c..5dc807d 100644
--- a/SpamBlacklist_body.php
+++ b/SpamBlacklist_body.php
@@ -252,9 +252,9 @@
                        'action' => $action,
                        'protocol' => $parsed['scheme'],
                        'domain' => $parsed['host'],
-                       'path' => $parsed['path'] !== null ? $parsed['path'] : 
'',
-                       'query' => $parsed['query'] !== null ? $parsed['query'] 
: '',
-                       'fragment' => $parsed['fragment'] !== null ? 
$parsed['fragment'] : '',
+                       'path' => isset( $parsed['path'] ) ? $parsed['path'] : 
'',
+                       'query' => isset( $parsed['query'] ) ? $parsed['query'] 
: '',
+                       'fragment' => isset( $parsed['fragment'] ) ? 
$parsed['fragment'] : '',
                );
 
                $this->urlChangeLog[] = $info;

-- 
To view, visit https://gerrit.wikimedia.org/r/342913
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8ebfb7dc9e513aa949cfc287d1a68b23f69d2784
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SpamBlacklist
Gerrit-Branch: master
Gerrit-Owner: Milimetric <[email protected]>
Gerrit-Reviewer: Jackmcbarn <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Milimetric <[email protected]>
Gerrit-Reviewer: Ottomata <[email protected]>
Gerrit-Reviewer: Reedy <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to