DLynch has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/345385 )
Change subject: Add template: don't try to add invalid templates when enter is
pressed
......................................................................
Add template: don't try to add invalid templates when enter is pressed
Bug: T161715
Change-Id: I12eabe3588fbcbed0fa18b94de7de7239ba490c2
---
M modules/ve-mw/ui/pages/ve.ui.MWTemplatePlaceholderPage.js
1 file changed, 7 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/85/345385/1
diff --git a/modules/ve-mw/ui/pages/ve.ui.MWTemplatePlaceholderPage.js
b/modules/ve-mw/ui/pages/ve.ui.MWTemplatePlaceholderPage.js
index 0ea00f3..14085e1 100644
--- a/modules/ve-mw/ui/pages/ve.ui.MWTemplatePlaceholderPage.js
+++ b/modules/ve-mw/ui/pages/ve.ui.MWTemplatePlaceholderPage.js
@@ -102,14 +102,19 @@
};
ve.ui.MWTemplatePlaceholderPage.prototype.onAddTemplate = function () {
- var part,
+ var part, name,
transclusion = this.placeholder.getTransclusion(),
menu = this.addTemplateInput.getLookupMenu();
if ( menu.isVisible() ) {
menu.chooseItem( menu.getSelectedItem() );
}
- part = ve.dm.MWTemplateModel.newFromName( transclusion,
this.addTemplateInput.getTitle() );
+ name = this.addTemplateInput.getTitle();
+ if ( !name ) {
+ // Invalid titles return null, so abort here.
+ return;
+ }
+ part = ve.dm.MWTemplateModel.newFromName( transclusion, name );
transclusion.replacePart( this.placeholder, part );
this.addTemplateInput.pushPending();
this.addTemplateButton.setDisabled( true );
--
To view, visit https://gerrit.wikimedia.org/r/345385
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I12eabe3588fbcbed0fa18b94de7de7239ba490c2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: DLynch <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
