Jdlrobson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/51324


Change subject: Bug 45378: Fix watchlist star jump
......................................................................

Bug 45378: Fix watchlist star jump

Negative margins are bad mkay.

Change-Id: Ide263f75679c5ed8093d6a21fdbdbb9d4d915b7b
---
M stylesheets/less/modules/mf-watchlist.less
M stylesheets/modules/mf-watchlist.css
2 files changed, 10 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/24/51324/1

diff --git a/stylesheets/less/modules/mf-watchlist.less 
b/stylesheets/less/modules/mf-watchlist.less
index 5f81d90..c7f3863 100644
--- a/stylesheets/less/modules/mf-watchlist.less
+++ b/stylesheets/less/modules/mf-watchlist.less
@@ -28,10 +28,12 @@
 
 li a.watch-this-article {
        right: @contentMarginRight;
-       top: 50%;
-       height: @searchResultPaddingVertical * 2;
+       top: 0;
+       bottom: 0;
+       height: 100%;
        width: @searchResultPaddingVertical * 2;
-       margin: -(@watchThisArticleSize / 2 + 1) 0 0;
+       background-position: center center;
+       margin: 0;
 }
 
 #mw-mf-menu-page {
diff --git a/stylesheets/modules/mf-watchlist.css 
b/stylesheets/modules/mf-watchlist.css
index 38d948a..8b6cc29 100644
--- a/stylesheets/modules/mf-watchlist.css
+++ b/stylesheets/modules/mf-watchlist.css
@@ -25,10 +25,12 @@
 }
 li a.watch-this-article {
   right: 23px;
-  top: 50%;
-  height: 24px;
+  top: 0;
+  bottom: 0;
+  height: 100%;
   width: 24px;
-  margin: -12px 0 0;
+  background-position: center center;
+  margin: 0;
 }
 #mw-mf-menu-page a.watch-this-article {
   position: absolute;

-- 
To view, visit https://gerrit.wikimedia.org/r/51324
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ide263f75679c5ed8093d6a21fdbdbb9d4d915b7b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to