jenkins-bot has submitted this change and it was merged.
Change subject: Remove isPageAppropriate entirely.
......................................................................
Remove isPageAppropriate entirely.
It was logged before, but in reality it was always truthy in the check,
since the function wasn't actually called.
Change-Id: I23a8ea07e5499a34bdbc5a218705b71f71e8a488
---
M experiments/acux/accountCreationUX.js
1 file changed, 1 insertion(+), 18 deletions(-)
Approvals:
Ori.livneh: Looks good to me, approved
jenkins-bot: Verified
diff --git a/experiments/acux/accountCreationUX.js
b/experiments/acux/accountCreationUX.js
index 6546cb7..f28de3b 100644
--- a/experiments/acux/accountCreationUX.js
+++ b/experiments/acux/accountCreationUX.js
@@ -831,22 +831,6 @@
return ( mw.user.isAnon() );
}
- // Page is usually Special:UserLogin?type=signup
- // But if e.g. Extension:SignupAPI is loaded, it runs.
- // Assert it's not a known user, i.e. someone already
logged in
- // is creating a new account
- function isPageAppropriate() {
- // Don't run if page is Special:UserSignup
- var pageName = config.get(
'wgCanonicalSpecialPageName' );
- var type = mw.util.getParamValue( 'type' );
- if ( DEBUG ) {
- if ( type !== 'signup' ) {
- log('page type is not signup??
(page inappropriate)');
- }
- }
- return ( pageName === 'Userlogin' && type ===
'signup' );
- }
-
function isExperimentOn() {
// TODO: DRY: get prefix from experiment name
if ( mw.util.getParamValue( 'acux_on' ) === "1"
) {
@@ -868,10 +852,9 @@
}
log( 'User eligible? ' +
isUserInExperiment() );
log( 'Experiment on? ' + isExperimentOn()
);
- log( 'Page appropriate? ' +
isPageAppropriate() );
}
- if ( isExperimentOn() && isPageAppropriate ) {
+ if ( isExperimentOn() ) {
// Prepare to log some info.
mw.eventLog.setDefaults( 'AccountCreation', {
--
To view, visit https://gerrit.wikimedia.org/r/51109
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I23a8ea07e5499a34bdbc5a218705b71f71e8a488
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/E3Experiments
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <[email protected]>
Gerrit-Reviewer: Mattflaschen <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: Spage <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
