jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/345478 )
Change subject: changeListeners: Conditionally empty link titles ...................................................................... changeListeners: Conditionally empty link titles If the user has disabled PP via the settings dialog or they aren't in the experimental condition, then link titles shouldn't be emptied. Because this behavior has to respond to the user enabling/disabling PP within the same page session, change the linkTitle change listener rather than conditionally registering it. Bug: T161277 Change-Id: I53c1a1d3e4436e2ffe08da27da388f394f4e8817 --- M resources/dist/index.js M resources/dist/index.js.map M src/changeListeners/linkTitle.js M tests/node-qunit/changeListeners/linkTitle.test.js 4 files changed, 18 insertions(+), 7 deletions(-) Approvals: jenkins-bot: Verified Jdlrobson: Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/345478 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53c1a1d3e4436e2ffe08da27da388f394f4e8817 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/Popups Gerrit-Branch: master Gerrit-Owner: Phuedx <samsm...@wikimedia.org> Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org> Gerrit-Reviewer: Jhernandez <jhernan...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
