jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/344882 )
Change subject: Hygiene: FETCH_END -> FETCH_COMPLETE ...................................................................... Hygiene: FETCH_END -> FETCH_COMPLETE Ideally, the preview model is resolved after 500 ms, regardless of whether the internal gateway takes 100 or 300 ms. Given this, there's an important distinction to be made between the "fetch" ending and it completing and their associated actions. Changes: * Dispatch the FETCH_COMPLETE action when the preview model is resolved. * Update the reducers accordingly. Change-Id: I62c9cb0430284b76338ea80bd170cac5af4be9d0 --- M resources/dist/index.js M resources/dist/index.js.map M src/actionTypes.js M src/actions.js M src/reducers/eventLogging.js M src/reducers/preview.js M src/reducers/statsv.js M tests/node-qunit/actions.test.js M tests/node-qunit/reducers/eventLogging.test.js M tests/node-qunit/reducers/preview.test.js M tests/node-qunit/reducers/statsv.test.js 11 files changed, 32 insertions(+), 30 deletions(-) Approvals: jenkins-bot: Verified Jdlrobson: Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/344882 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62c9cb0430284b76338ea80bd170cac5af4be9d0 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/Popups Gerrit-Branch: master Gerrit-Owner: Phuedx <[email protected]> Gerrit-Reviewer: Bmansurov <[email protected]> Gerrit-Reviewer: Jdlrobson <[email protected]> Gerrit-Reviewer: Jhernandez <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
