Hello Giuseppe Lavagetto, Subramanya Sastry, Mobrovac, jenkins-bot,

I'd like you to do a code review.  Please visit

    https://gerrit.wikimedia.org/r/345944

to review the following change.


Change subject: Revert "parsoid-testing: add logrotate"
......................................................................

Revert "parsoid-testing: add logrotate"

This reverts commit f700788cbb97d5191566353f4e97d787af366604.

Change-Id: I079f64a9b9ad30f4ab6c3185c4e46a9f1db7a872
---
D modules/parsoid/files/parsoid_testing.logrotate.conf
M modules/role/manifests/parsoid/testing.pp
2 files changed, 0 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/44/345944/1

diff --git a/modules/parsoid/files/parsoid_testing.logrotate.conf 
b/modules/parsoid/files/parsoid_testing.logrotate.conf
deleted file mode 100644
index e724dbe..0000000
--- a/modules/parsoid/files/parsoid_testing.logrotate.conf
+++ /dev/null
@@ -1,14 +0,0 @@
-#####################################################################
-### THIS FILE IS MANAGED BY PUPPET
-### puppet:///modules/parsoid/parsoid_testing_logrotate
-#####################################################################
-
-/srv/log/parsoid/main.log {
-    daily
-    compress
-    delaycompress
-    missingok
-    notifempty
-    rotate 7
-}
-
diff --git a/modules/role/manifests/parsoid/testing.pp 
b/modules/role/manifests/parsoid/testing.pp
index e37e572..c4fa9b4 100644
--- a/modules/role/manifests/parsoid/testing.pp
+++ b/modules/role/manifests/parsoid/testing.pp
@@ -52,11 +52,6 @@
         notify  => Service['nginx'],
     }
 
-    logrotate::conf { 'parsoid_testing':
-        ensure => 'present',
-        source => 'puppet:///modules/parsoid/parsoid_testing.logrotate.conf',
-    }
-
     ferm::service { 'nginx-parsoid-testing':
         proto  => 'tcp',
         port   => 8001,

-- 
To view, visit https://gerrit.wikimedia.org/r/345944
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I079f64a9b9ad30f4ab6c3185c4e46a9f1db7a872
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn <dz...@wikimedia.org>
Gerrit-Reviewer: Giuseppe Lavagetto <glavage...@wikimedia.org>
Gerrit-Reviewer: Mobrovac <mobro...@wikimedia.org>
Gerrit-Reviewer: Subramanya Sastry <ssas...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to