Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/345945 )
Change subject: phpunit: Remove unused assertNotTag() method
......................................................................
phpunit: Remove unused assertNotTag() method
Deprecated since PHPUnit 4.2, we use PHPUnit 4.8 and would like
to be compatible with PHPUnit 5 which no longer has this method.
The current hack was only enough to avoid the deprecation warning,
the underlying logic in Xml::findNodes() was also removed in PHPUnit 5.
There are 3 uses of assertTag() in all Wikimedia Git. However
there are 0 of assertNotTag(), so let's start with removing that.
Follows-up 23ec64745c, dba0522f70, T71505.
Change-Id: I56b8f1f88124d69190938fc522ea75419e96c49c
---
M tests/phpunit/MediaWikiTestCase.php
1 file changed, 0 insertions(+), 15 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/45/345945/1
diff --git a/tests/phpunit/MediaWikiTestCase.php
b/tests/phpunit/MediaWikiTestCase.php
index 419ff00..dcdad1a 100644
--- a/tests/phpunit/MediaWikiTestCase.php
+++ b/tests/phpunit/MediaWikiTestCase.php
@@ -1799,21 +1799,6 @@
}
/**
- * @see MediaWikiTestCase::assertTag
- * @deprecated
- *
- * @param array $matcher
- * @param string $actual
- * @param string $message
- * @param bool $isHtml
- */
- public static function assertNotTag( $matcher, $actual, $message = '',
$isHtml = true ) {
- // trigger_error(__METHOD__ . ' is deprecated',
E_USER_DEPRECATED);
-
- self::assertFalse( self::tagMatch( $matcher, $actual, $isHtml
), $message );
- }
-
- /**
* Used as a marker to prevent wfResetOutputBuffers from breaking
PHPUnit.
* @return string
*/
--
To view, visit https://gerrit.wikimedia.org/r/345945
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I56b8f1f88124d69190938fc522ea75419e96c49c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <krinklem...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
