jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/345952 )
Change subject: FauxRequest: Complete code coverage for FauxRequestTest
......................................................................
FauxRequest: Complete code coverage for FauxRequestTest
Follows-up d18d030d57b88.
* Add missing case of session being a Session object.
Change-Id: I7da0c6d4a6483d53bcfd56751cd1cb669bd5023e
---
M tests/phpunit/includes/FauxRequestTest.php
1 file changed, 13 insertions(+), 0 deletions(-)
Approvals:
Aaron Schulz: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/phpunit/includes/FauxRequestTest.php
b/tests/phpunit/includes/FauxRequestTest.php
index e3713ab..9fe694d 100644
--- a/tests/phpunit/includes/FauxRequestTest.php
+++ b/tests/phpunit/includes/FauxRequestTest.php
@@ -1,5 +1,7 @@
<?php
+use MediaWiki\Session\SessionManager;
+
class FauxRequestTest extends PHPUnit_Framework_TestCase {
/**
* @covers FauxRequest::__construct
@@ -18,6 +20,17 @@
}
/**
+ * @covers FauxRequest::__construct
+ */
+ public function testConstructWithSession() {
+ $session = SessionManager::singleton()->getEmptySession( new
FauxRequest( [] ) );
+ $this->assertInstanceOf(
+ FauxRequest::class,
+ new FauxRequest( [], false, $session )
+ );
+ }
+
+ /**
* @covers FauxRequest::getText
*/
public function testGetText() {
--
To view, visit https://gerrit.wikimedia.org/r/345952
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7da0c6d4a6483d53bcfd56751cd1cb669bd5023e
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: Aaron Schulz <asch...@wikimedia.org>
Gerrit-Reviewer: Anomie <bjor...@wikimedia.org>
Gerrit-Reviewer: Gergő Tisza <gti...@wikimedia.org>
Gerrit-Reviewer: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
