jenkins-bot has submitted this change and it was merged.
Change subject: (bug 45494) Make "translated" the default filter for
proofreading
......................................................................
(bug 45494) Make "translated" the default filter for proofreading
Change-Id: Ifef5276a3a99fcd0a69abf2b173f332da93adcee
---
M resources/js/ext.translate.messagetable.js
1 file changed, 10 insertions(+), 7 deletions(-)
Approvals:
Nikerabbit: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/js/ext.translate.messagetable.js
b/resources/js/ext.translate.messagetable.js
index c22224c..6547815 100644
--- a/resources/js/ext.translate.messagetable.js
+++ b/resources/js/ext.translate.messagetable.js
@@ -368,7 +368,8 @@
* @param {string} mode The message table mode - proofread or
translate
*/
switchMode: function ( mode ) {
- var messageTable = this;
+ var messageTable = this,
+ filter = messageTable.$loader.data( 'filter' );
messageTable.$actionBar.find( '.down' ).removeClass(
'down' );
if ( mode === 'translate' ) {
@@ -389,17 +390,19 @@
if ( messageTable.mode === 'proofread' ) {
$( '.tux-message-selector >
.tux-tab-untranslated' ).addClass( 'hide' );
+ // Fix the filter if it is untranslated.
Untranslated does not make sense
+ // for proofread mode. Keep the filter if it is
not 'untranslated'
+ if ( filter.indexOf( '!translated' ) >= 0 ) {
+ messageTable.messages = [];
+ mw.translate.changeFilter( 'translated'
);
+ $( '.tux-message-selector >
.tux-tab-translated' ).addClass( 'selected' );
+ }
} else {
$( '.tux-message-selector >
.tux-tab-untranslated' ).removeClass( 'hide' );
}
$.each( messageTable.messages, function ( index,
message ) {
- if ( messageTable.mode === 'translate' ) {
- messageTable.addTranslate( message );
- }
- if ( messageTable.mode === 'proofread' ) {
- messageTable.addProofread( message );
- }
+ messageTable.add( message );
} );
},
--
To view, visit https://gerrit.wikimedia.org/r/51344
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifef5276a3a99fcd0a69abf2b173f332da93adcee
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Santhosh <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: Santhosh <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
