Awight has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346207 )
Change subject: Assert stderr goes to the output file ...................................................................... Assert stderr goes to the output file Change-Id: Iaddb2bbae18a4e733842998995b6b84982b507af --- M tests/test_job_wrapper.py 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/process-control refs/changes/07/346207/1 diff --git a/tests/test_job_wrapper.py b/tests/test_job_wrapper.py index e02d3af..73cf23d 100644 --- a/tests/test_job_wrapper.py +++ b/tests/test_job_wrapper.py @@ -78,6 +78,9 @@ assert ("errors", "ERROR", "grep: Invalid regular expression") in loglines # TODO: Should we go out of our way to log the non-zero return code as well? + lines = get_output_lines("errors") + assert "ERROR\tgrep: Invalid regular expression" in lines + MockSmtp().sendmail.assert_called_once() -- To view, visit https://gerrit.wikimedia.org/r/346207 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iaddb2bbae18a4e733842998995b6b84982b507af Gerrit-PatchSet: 1 Gerrit-Project: wikimedia/fundraising/process-control Gerrit-Branch: master Gerrit-Owner: Awight <awi...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits