jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/344745 )
Change subject: resourceloader: Use Array#map instead of jQuery#map for arrays ...................................................................... resourceloader: Use Array#map instead of jQuery#map for arrays Upto 50% faster, depending on the browser. https://gist.github.com/Krinkle/4a22236022027af511b8d33feab0c4c2#gistcomment-2037282 Also change confusing parameter name 'i' to 'obj' in getModuleNames(). This one can't be changed since it loops over an object, not an array. Bug: T160953 Change-Id: I85d6348670703c7ef061ba735ea441a1fc008062 --- M resources/src/mediawiki/mediawiki.js 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Bartosz Dziewoński: Looks good to me, approved jenkins-bot: Verified Jforrester: Looks good to me, but someone else must approve diff --git a/resources/src/mediawiki/mediawiki.js b/resources/src/mediawiki/mediawiki.js index c2cee7e..b963c7b 100644 --- a/resources/src/mediawiki/mediawiki.js +++ b/resources/src/mediawiki/mediawiki.js @@ -983,7 +983,7 @@ * @return {string} Hash of concatenated version hashes. */ function getCombinedVersion( modules ) { - var hashes = $.map( modules, function ( module ) { + var hashes = modules.map( function ( module ) { return registry[ module ].version; } ); return fnv132( hashes.join( '' ) ); @@ -2146,7 +2146,7 @@ * @return {Array} */ getModuleNames: function () { - return $.map( registry, function ( i, key ) { + return $.map( registry, function ( obj, key ) { return key; } ); }, @@ -2778,7 +2778,7 @@ // for all loading modules. If one fails, fall back to tracking each module // separately via $.when(), this is expensive. loading = mw.loader.using( loading ).then( null, function () { - var all = $.map( loading, function ( module ) { + var all = loading.map( function ( module ) { return mw.loader.using( module ).then( null, function () { return $.Deferred().resolve(); } ); -- To view, visit https://gerrit.wikimedia.org/r/344745 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85d6348670703c7ef061ba735ea441a1fc008062 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Krinkle <[email protected]> Gerrit-Reviewer: Bartosz Dziewoński <[email protected]> Gerrit-Reviewer: Jack Phoenix <[email protected]> Gerrit-Reviewer: Jforrester <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
