Jforrester has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/346485 )
Change subject: EventEmitter#disconnect: Correct documentation for second
parameter
......................................................................
EventEmitter#disconnect: Correct documentation for second parameter
The documentation suggested that <string,Array> would work, but it didn't.
We may add this as a feature in future (T100731) but for now we shouldn't
mislead.
Change-Id: I5e8575d8006e44eaacfc7e4c51177244f8c3947d
---
M src/EventEmitter.js
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/core refs/changes/85/346485/1
diff --git a/src/EventEmitter.js b/src/EventEmitter.js
index 169f3a8..852256d 100644
--- a/src/EventEmitter.js
+++ b/src/EventEmitter.js
@@ -216,9 +216,9 @@
* Disconnect event handlers from an object.
*
* @param {Object} context Object to disconnect methods from
- * @param
{Object.<string,string>|Object.<string,Function>|Object.<string,Array>}
[methods] List of
- * event bindings keyed by event name. Values can be either method
names or functions, but must be
- * consistent with those used in the corresponding call to "connect".
+ * @param {Object.<string,string>|Object.<string,Function>} [methods]
List of event bindings
+ * keyed by event name. Values can be either method names or functions,
but must be consistent
+ * with those used in the corresponding call to "connect".
* @chainable
*/
oo.EventEmitter.prototype.disconnect = function ( context, methods ) {
--
To view, visit https://gerrit.wikimedia.org/r/346485
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5e8575d8006e44eaacfc7e4c51177244f8c3947d
Gerrit-PatchSet: 1
Gerrit-Project: oojs/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
