Fomafix has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/346492 )
Change subject: Replace deprecated jQuery.isArray by Array.isArray
......................................................................
Replace deprecated jQuery.isArray by Array.isArray
jQuery.isArray is deprecated since jQuery 3.2.0. [1]
Array.isArray is part of ES5 and is supported since the following browser
versions: [2]
* Chrome 5
* Firefox (Gecko) 4.0 (2.0)
* Internet Explorer 9
* Opera 10.5
* Safari 5
This change requires MediaWiki 1.29+ which ensures that JavaScript is only
used when the browser supports ES5.
Performed using:
find . -type f -name \*.js -exec sed -i -e 's/\$\.isArray/Array.isArray/g' {} \;
[1] https://blog.jquery.com/2017/03/16/jquery-3-2-0-is-out/
[2]
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/isArray#Browser_compatibility
Change-Id: Ia0549722934ee4dbe4649d97073032c332be22f5
---
M lib/tests/qunit/wikibase.sites.tests.js
M view/resources/jquery/wikibase/jquery.wikibase.entityselector.js
M
view/resources/jquery/wikibase/jquery.wikibase.entitytermsforlanguagelistview.js
M view/resources/jquery/wikibase/jquery.wikibase.entitytermsview.js
M view/resources/wikibase/templates.js
M view/resources/wikibase/view/ViewFactory.js
M view/tests/qunit/wikibase/templates.tests.js
7 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/92/346492/1
diff --git a/lib/tests/qunit/wikibase.sites.tests.js
b/lib/tests/qunit/wikibase.sites.tests.js
index b98e60b..7a1f807 100644
--- a/lib/tests/qunit/wikibase.sites.tests.js
+++ b/lib/tests/qunit/wikibase.sites.tests.js
@@ -150,7 +150,7 @@
var siteGroups = wb.sites.getSiteGroups();
assert.strictEqual(
- $.isArray( siteGroups ),
+ Array.isArray( siteGroups ),
true,
'getSiteGroups() returns Array'
);
diff --git a/view/resources/jquery/wikibase/jquery.wikibase.entityselector.js
b/view/resources/jquery/wikibase/jquery.wikibase.entityselector.js
index 565ad3b..006ec5c 100644
--- a/view/resources/jquery/wikibase/jquery.wikibase.entityselector.js
+++ b/view/resources/jquery/wikibase/jquery.wikibase.entityselector.js
@@ -138,7 +138,7 @@
+ 'be specified.' );
}
this.options.source = this._initDefaultSource();
- } else if ( !$.isFunction( this.options.source ) && !$.isArray(
this.options.source ) ) {
+ } else if ( !$.isFunction( this.options.source ) &&
!Array.isArray( this.options.source ) ) {
throw new Error( 'Source needs to be a function or an
array' );
}
diff --git
a/view/resources/jquery/wikibase/jquery.wikibase.entitytermsforlanguagelistview.js
b/view/resources/jquery/wikibase/jquery.wikibase.entitytermsforlanguagelistview.js
index 8eb4c5b..91dfb59 100644
---
a/view/resources/jquery/wikibase/jquery.wikibase.entitytermsforlanguagelistview.js
+++
b/view/resources/jquery/wikibase/jquery.wikibase.entitytermsforlanguagelistview.js
@@ -70,7 +70,7 @@
*/
_create: function() {
if ( !( this.options.value instanceof wb.datamodel.Fingerprint )
- || !$.isArray( this.options.userLanguages )
+ || !Array.isArray( this.options.userLanguages )
) {
throw new Error( 'Required option(s) missing' );
}
diff --git a/view/resources/jquery/wikibase/jquery.wikibase.entitytermsview.js
b/view/resources/jquery/wikibase/jquery.wikibase.entitytermsview.js
index 1830270..a0ce17b 100644
--- a/view/resources/jquery/wikibase/jquery.wikibase.entitytermsview.js
+++ b/view/resources/jquery/wikibase/jquery.wikibase.entitytermsview.js
@@ -85,7 +85,7 @@
*/
_create: function() {
if ( !( this.options.value instanceof wb.datamodel.Fingerprint )
- || !$.isArray( this.options.userLanguages )
+ || !Array.isArray( this.options.userLanguages )
) {
throw new Error( 'Required option(s) missing' );
}
diff --git a/view/resources/wikibase/templates.js
b/view/resources/wikibase/templates.js
index 040f0bc..c5a0c24 100644
--- a/view/resources/wikibase/templates.js
+++ b/view/resources/wikibase/templates.js
@@ -236,7 +236,7 @@
delayedParams = [];
if ( parameter1 !== undefined ) {
- if ( $.isArray( parameter1 ) ) {
+ if ( Array.isArray( parameter1 ) ) {
params = parameter1;
} else { // support variadic arguments
params = Array.prototype.slice.call( arguments
);
diff --git a/view/resources/wikibase/view/ViewFactory.js
b/view/resources/wikibase/view/ViewFactory.js
index 762b09a..b7556ab 100644
--- a/view/resources/wikibase/view/ViewFactory.js
+++ b/view/resources/wikibase/view/ViewFactory.js
@@ -56,7 +56,7 @@
) {
if ( ( !structureEditorFactory ||
!structureEditorFactory.getAdder )
|| ( !messageProvider || !messageProvider.getMessage )
- || !$.isArray( userLanguages )
+ || !Array.isArray( userLanguages )
|| ( vocabularyLookupApiUrl && typeof
vocabularyLookupApiUrl !== 'string'
|| !commonsApiUrl )
) {
diff --git a/view/tests/qunit/wikibase/templates.tests.js
b/view/tests/qunit/wikibase/templates.tests.js
index fe8e043..aa526dc 100644
--- a/view/tests/qunit/wikibase/templates.tests.js
+++ b/view/tests/qunit/wikibase/templates.tests.js
@@ -177,7 +177,7 @@
return string.replace( /</g, '<' ).replace(
/>/g, '>' );
}
- if ( !$.isArray( params ) ) {
+ if ( !Array.isArray( params ) ) {
params = [ params ];
}
@@ -195,7 +195,7 @@
}
} );
- if ( $.isArray( expected ) ) {
+ if ( Array.isArray( expected ) ) {
expected = ( $.client.profile().name === 'msie'
) ? expected[1] : expected[0];
}
--
To view, visit https://gerrit.wikimedia.org/r/346492
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia0549722934ee4dbe4649d97073032c332be22f5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Fomafix <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
