Reedy has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/346593 )

Change subject: Fix phpunit test added in 57efcafa8a3a64f
......................................................................


Fix phpunit test added in 57efcafa8a3a64f

ObjectFactory wasn't added until 1.25

Change-Id: I865d40029608534a8eceffa66fb10ad17aa865ac
---
M tests/phpunit/includes/MessageTest.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Reedy: Verified; Looks good to me, approved



diff --git a/tests/phpunit/includes/MessageTest.php 
b/tests/phpunit/includes/MessageTest.php
index 5895581..3554956 100644
--- a/tests/phpunit/includes/MessageTest.php
+++ b/tests/phpunit/includes/MessageTest.php
@@ -152,7 +152,7 @@
                // to register the html hook
                MessageCache::destroyInstance();
                $this->setMwGlobals( 'wgParser',
-                       ObjectFactory::constructClassInstance( 
$wgParserConf['class'], array( $wgParserConf ) )
+                       new $wgParserConf['class']( array( $wgParserConf ) )
                );
 
                $msg = new RawMessage( 
'<html><script>alert("xss")</script></html>' );

-- 
To view, visit https://gerrit.wikimedia.org/r/346593
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I865d40029608534a8eceffa66fb10ad17aa865ac
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/core
Gerrit-Branch: REL1_23
Gerrit-Owner: Brian Wolff <[email protected]>
Gerrit-Reviewer: Reedy <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to