jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/346614 )
Change subject: Rename BaseTemplate::clear to getClear to avoid conflicts with
Example skin and derivatives
......................................................................
Rename BaseTemplate::clear to getClear to avoid conflicts
with Example skin and derivatives
Also it's a bit more consistent with everything else anyway.
Change-Id: I2745d51267790e93fe2b92a75e88621abbb57fd1
---
M includes/skins/BaseTemplate.php
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/skins/BaseTemplate.php b/includes/skins/BaseTemplate.php
index dc0a703..5868904 100644
--- a/includes/skins/BaseTemplate.php
+++ b/includes/skins/BaseTemplate.php
@@ -699,7 +699,7 @@
$html .= Html::closeElement( 'ul' );
}
- $html .= $this->clear() . $footerEnd;
+ $html .= $this->getClear() . $footerEnd;
return $html;
}
@@ -710,7 +710,7 @@
* @return string html
* @since 1.29
*/
- protected function clear() {
+ protected function getClear() {
return Html::element( 'div', [ 'class' => 'visualClear' ] );
}
--
To view, visit https://gerrit.wikimedia.org/r/346614
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2745d51267790e93fe2b92a75e88621abbb57fd1
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Isarra <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Jack Phoenix <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
