jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/346692 )
Change subject: CX2: Fix JS error with references
......................................................................
CX2: Fix JS error with references
The content for card was coming as null because of the way we get it.
This is still fragile. The right way to do is wt2html of the template
definition for the reference. The current approach just grabs the HTML
from References section.
Change-Id: Ic627db97a59780a3c058010ef1d013fe04893ab9
---
M modules/dm/translationunits/mw.cx.dm.ReferenceTranslationUnit.js
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
Nikerabbit: Looks good to me, approved
diff --git a/modules/dm/translationunits/mw.cx.dm.ReferenceTranslationUnit.js
b/modules/dm/translationunits/mw.cx.dm.ReferenceTranslationUnit.js
index 53d9d9c..c490447 100644
--- a/modules/dm/translationunits/mw.cx.dm.ReferenceTranslationUnit.js
+++ b/modules/dm/translationunits/mw.cx.dm.ReferenceTranslationUnit.js
@@ -59,9 +59,10 @@
<span id="mw-reference-text-cite_note-three-3"
class="mw-reference-text" data-parsoid="{}">Three</span>
</li>
</li>
+ The href value can also be like
href='./Title#cite_ref-three_3-0'
*/
$referenceContent = $( this.translation.sourcePage.sections )
- .find( 'a[href="#' + this.sourceDocument.id + '"]' )
+ .find( 'a[href$="#' + this.sourceDocument.id + '"]' )
.closest( 'li' )
.find( '.mw-reference-text' );
if ( $referenceContent.length > 0 ) {
--
To view, visit https://gerrit.wikimedia.org/r/346692
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic627db97a59780a3c058010ef1d013fe04893ab9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Santhosh <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
