Paladox has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/346916 )

Change subject: Use default wiki id in example settings.
......................................................................

Use default wiki id in example settings.

Until now, we force the local wiki ID to "mywiki" in the exampel settings.
This triggers a warning if "mywiki" is not known to the SiteLookup.

Instead of forcing a fixed value, we can just rely on the default for the
local site ID, which is the wiki's database name. That is consistent with
the conventions used on the WMF cluster.

Bug: T153729
Change-Id: Ia0d578a8215280592001cfa5f413fb76e15a2d2f
(cherry picked from commit 8e5d3af54d8c5da0783ce1427c8deaf2d1a5d284)
(cherry picked from commit 166c4fc5b71f691c5b78579a4ab1ce69d940b777)
---
M client/config/WikibaseClient.example.php
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/16/346916/1

diff --git a/client/config/WikibaseClient.example.php 
b/client/config/WikibaseClient.example.php
index 922cc2b..d54a763 100644
--- a/client/config/WikibaseClient.example.php
+++ b/client/config/WikibaseClient.example.php
@@ -19,7 +19,8 @@
 }
 
 // The global site ID by which this wiki is known on the repo.
-$wgWBClientSettings['siteGlobalID'] = "mywiki";
+// Defaults to $wgDBname.
+// $wgWBClientSettings['siteGlobalID'] = "mywiki";
 
 $wgWBClientSettings['injectRecentChanges'] = true;
 $wgWBClientSettings['showExternalRecentChanges'] = true;

-- 
To view, visit https://gerrit.wikimedia.org/r/346916
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia0d578a8215280592001cfa5f413fb76e15a2d2f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: REL1_27
Gerrit-Owner: Paladox <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to