Jforrester has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/346918 )
Change subject: stylelint: Drop no-unsupported-browser-features references
......................................................................
stylelint: Drop no-unsupported-browser-features references
The rule hasn't been applied for a while, as it was deprecated upstream.
Change-Id: Ibef4f2dc8508983baab2094952cf2649a99fab36
---
M demos/ve/demo.css
M src/ce/styles/nodes/ve.ce.ActiveNode.css
M src/ce/styles/nodes/ve.ce.AlienNode.css
M src/ce/styles/nodes/ve.ce.BranchNode.css
M src/ce/styles/nodes/ve.ce.FocusableNode.css
M src/ce/styles/nodes/ve.ce.ResizableNode.css
M src/ce/styles/nodes/ve.ce.SectionNode.css
M src/ce/styles/nodes/ve.ce.TableCellNode.css
M src/ce/styles/nodes/ve.ce.TableNode.css
M src/ui/styles/dialogs/ve.ui.CommandHelpDialog.css
M src/ui/styles/dialogs/ve.ui.FindAndReplaceDialog.css
M src/ui/styles/dialogs/ve.ui.SpecialCharacterDialog.css
M src/ui/styles/dialogs/ve.ui.ToolbarDialog.css
M src/ui/styles/elements/ve.ui.DiffElement.css
M src/ui/styles/ve.ui.ContextItem.css
M src/ui/styles/ve.ui.DebugBar.css
M src/ui/styles/ve.ui.DesktopContext.css
M src/ui/styles/ve.ui.Overlay.css
M src/ui/styles/ve.ui.Toolbar.css
19 files changed, 18 insertions(+), 47 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/18/346918/1
diff --git a/demos/ve/demo.css b/demos/ve/demo.css
index e544b19..5a70bfc 100644
--- a/demos/ve/demo.css
+++ b/demos/ve/demo.css
@@ -19,7 +19,7 @@
float: right;
margin: 0.5em 0 0 0;
background-repeat: no-repeat;
- background-size: contain; /* stylelint-disable-line
no-unsupported-browser-features */
+ background-size: contain;
}
.ve-pad-logo {
diff --git a/src/ce/styles/nodes/ve.ce.ActiveNode.css
b/src/ce/styles/nodes/ve.ce.ActiveNode.css
index c64b817..079785e 100644
--- a/src/ce/styles/nodes/ve.ce.ActiveNode.css
+++ b/src/ce/styles/nodes/ve.ce.ActiveNode.css
@@ -10,5 +10,5 @@
.ve-ce-focusableNode .ve-ce-activeNode,
.ve-ce-focusableNode .ve-ce-activeNode * {
- -moz-user-select: text; /* stylelint-disable-line
no-unsupported-browser-features */
+ -moz-user-select: text;
}
diff --git a/src/ce/styles/nodes/ve.ce.AlienNode.css
b/src/ce/styles/nodes/ve.ce.AlienNode.css
index 24a2b98..88145a9 100644
--- a/src/ce/styles/nodes/ve.ce.AlienNode.css
+++ b/src/ce/styles/nodes/ve.ce.AlienNode.css
@@ -6,21 +6,17 @@
.ve-ce-alienNode-highlights .ve-ce-focusableNode-highlight {
background-color: #95d14f;
- /* stylelint-disable no-unsupported-browser-features */
background-image: -webkit-repeating-linear-gradient( -45deg, #fff 0,
#fff 5px, #95d14f 5px, #95d14f 10px );
background-image: -moz-repeating-linear-gradient( -45deg, #fff 0, #fff
5px, #95d14f 5px, #95d14f 10px );
background-image: repeating-linear-gradient( -45deg, #fff 0, #fff 5px,
#95d14f 5px, #95d14f 10px );
background-size: 14px 14px;
cursor: not-allowed;
- /* stylelint-enable no-unsupported-browser-features */
}
.ve-ce-surface-highlights-focused .ve-ce-alienNode-highlights
.ve-ce-focusableNode-highlight {
- /* stylelint-disable no-unsupported-browser-features */
background-image: -webkit-repeating-linear-gradient( -45deg, #6da9f7 0,
#6da9f7 5px, #95d14f 5px, #95d14f 10px );
background-image: -moz-repeating-linear-gradient( -45deg, #6da9f7 0,
#6da9f7 5px, #95d14f 5px, #95d14f 10px );
background-image: repeating-linear-gradient( -45deg, #6da9f7 0, #6da9f7
5px, #95d14f 5px, #95d14f 10px );
- /* stylelint-enable no-unsupported-browser-features */
}
.ve-ce-surface-highlights-blurred .ve-ce-alienNode-highlights {
diff --git a/src/ce/styles/nodes/ve.ce.BranchNode.css
b/src/ce/styles/nodes/ve.ce.BranchNode.css
index bc22d1d..4e8f033 100644
--- a/src/ce/styles/nodes/ve.ce.BranchNode.css
+++ b/src/ce/styles/nodes/ve.ce.BranchNode.css
@@ -13,11 +13,9 @@
visibility: hidden;
opacity: 0;
cursor: pointer;
- /* stylelint-disable no-unsupported-browser-features */
-webkit-transition: opacity 200ms ease-out;
-moz-transition: opacity 200ms ease-out;
transition: opacity 200ms ease-out;
- /* stylelint-enable no-unsupported-browser-features */
}
.ve-ce-branchNode-blockSlug,
@@ -42,11 +40,9 @@
background-color: transparent;
outline-color: transparent;
outline-offset: 1em;
- /* stylelint-disable no-unsupported-browser-features */
-webkit-transition: all 400ms ease-out;
-moz-transition: all 400ms ease-out;
transition: all 400ms ease-out;
- /* stylelint-enable no-unsupported-browser-features */
}
.ve-ce-branchNode-blockSlug > .oo-ui-buttonWidget {
@@ -62,7 +58,7 @@
.ve-ce-branchNode-blockSlug > .oo-ui-buttonWidget >
.oo-ui-buttonElement-button > .oo-ui-iconElement-icon {
width: 0.95em;
height: 0.95em;
- background-size: auto; /* stylelint-disable-line
no-unsupported-browser-features */
+ background-size: auto;
}
.ve-ce-chimera {
diff --git a/src/ce/styles/nodes/ve.ce.FocusableNode.css
b/src/ce/styles/nodes/ve.ce.FocusableNode.css
index 8ef302f..a260693 100644
--- a/src/ce/styles/nodes/ve.ce.FocusableNode.css
+++ b/src/ce/styles/nodes/ve.ce.FocusableNode.css
@@ -13,7 +13,7 @@
.ve-ce-focusableNode * {
/* Support: Firefox */
/* T70537: work around Firefox bug */
- -moz-user-select: none; /* stylelint-disable-line
no-unsupported-browser-features */
+ -moz-user-select: none;
}
.ve-ce-focusableNode-highlight {
@@ -62,7 +62,7 @@
/* Don't scale icon in headings etc. */
width: 24px;
height: 24px;
- background-size: 24px 24px; /* stylelint-disable-line
no-unsupported-browser-features */
+ background-size: 24px 24px;
/* Make native selection match fake selection */
font-size: 24px;
line-height: 1em;
diff --git a/src/ce/styles/nodes/ve.ce.ResizableNode.css
b/src/ce/styles/nodes/ve.ce.ResizableNode.css
index b4f7369..4c06336 100644
--- a/src/ce/styles/nodes/ve.ce.ResizableNode.css
+++ b/src/ce/styles/nodes/ve.ce.ResizableNode.css
@@ -70,11 +70,9 @@
position: absolute;
text-align: center;
opacity: 0;
- /* stylelint-disable no-unsupported-browser-features */
-webkit-transition: opacity 200ms;
-moz-transition: opacity 200ms;
transition: opacity 200ms;
- /* stylelint-enable no-unsupported-browser-features */
}
.ve-ce-resizableNode-sizeLabel-resizing {
diff --git a/src/ce/styles/nodes/ve.ce.SectionNode.css
b/src/ce/styles/nodes/ve.ce.SectionNode.css
index 5f7e8ad..fcce3fb 100644
--- a/src/ce/styles/nodes/ve.ce.SectionNode.css
+++ b/src/ce/styles/nodes/ve.ce.SectionNode.css
@@ -15,11 +15,9 @@
.ve-ce-documentNode .ve-ce-sectionNode {
opacity: 0.5;
- /* stylelint-disable no-unsupported-browser-features */
-webkit-transition: opacity 250ms ease;
-moz-transition: opacity 250ms ease;
transition: opacity 250ms ease;
- /* stylelint-enable no-unsupported-browser-features */
}
.ve-ce-documentNode .ve-ce-sectionNode.ve-ce-activeNode-active {
diff --git a/src/ce/styles/nodes/ve.ce.TableCellNode.css
b/src/ce/styles/nodes/ve.ce.TableCellNode.css
index 3676b90..3ce0bf8 100644
--- a/src/ce/styles/nodes/ve.ce.TableCellNode.css
+++ b/src/ce/styles/nodes/ve.ce.TableCellNode.css
@@ -15,11 +15,11 @@
}
.ve-ce-tableCellNode a {
- pointer-events: none; /* stylelint-disable-line
no-unsupported-browser-features */
+ pointer-events: none;
}
.ve-ce-tableCellNode-editing a {
- pointer-events: auto; /* stylelint-disable-line
no-unsupported-browser-features */
+ pointer-events: auto;
}
.ve-ce-tableCellNode > .ve-ce-branchNode-blockSlug {
diff --git a/src/ce/styles/nodes/ve.ce.TableNode.css
b/src/ce/styles/nodes/ve.ce.TableNode.css
index e037dae..3b6a4d1 100644
--- a/src/ce/styles/nodes/ve.ce.TableNode.css
+++ b/src/ce/styles/nodes/ve.ce.TableNode.css
@@ -22,11 +22,11 @@
.ve-ce-tableNodeOverlay {
position: absolute;
- pointer-events: none; /* stylelint-disable-line
no-unsupported-browser-features */
+ pointer-events: none;
}
.ve-ce-tableNodeOverlay .ve-ui-tableLineContext {
- pointer-events: auto; /* stylelint-disable-line
no-unsupported-browser-features */
+ pointer-events: auto;
}
.ve-ce-tableNodeOverlay-selection-box {
@@ -50,11 +50,9 @@
}
.ve-ce-tableNodeOverlay-selection-box-notEditable {
- /* stylelint-disable no-unsupported-browser-features */
background-image: -webkit-repeating-linear-gradient( -45deg,
transparent 0 transparent 5px, #95d14f 5px, #95d14f 10px );
background-image: -moz-repeating-linear-gradient( -45deg, transparent
0, transparent 5px, #95d14f 5px, #95d14f 10px );
background-image: repeating-linear-gradient( -45deg, transparent 0,
transparent 5px, #95d14f 5px, #95d14f 10px );
- /* stylelint-enable no-unsupported-browser-features */
}
.ve-ce-tableNodeOverlay-selection-box-anchor {
diff --git a/src/ui/styles/dialogs/ve.ui.CommandHelpDialog.css
b/src/ui/styles/dialogs/ve.ui.CommandHelpDialog.css
index dfcb5f5..730342e 100644
--- a/src/ui/styles/dialogs/ve.ui.CommandHelpDialog.css
+++ b/src/ui/styles/dialogs/ve.ui.CommandHelpDialog.css
@@ -5,13 +5,10 @@
*/
.ve-ui-commandHelpDialog-container {
- /* TODO: IE9 doesn't support column layouts T135379 */
- /* stylelint-disable no-unsupported-browser-features */
-ms-column-count: 3;
-moz-column-count: 3;
-webkit-column-count: 3;
column-count: 3;
- /* stylelint-enable no-unsupported-browser-features */
}
.ve-ui-commandHelpDialog-section {
@@ -80,7 +77,7 @@
line-height: 1.4;
padding: 0.1em 0.4em;
margin: -0.1em 0.3em 0;
- text-shadow: 0 1px 0 #fff; /* stylelint-disable-line
no-unsupported-browser-features */
+ text-shadow: 0 1px 0 #fff;
text-transform: uppercase;
text-align: center;
}
diff --git a/src/ui/styles/dialogs/ve.ui.FindAndReplaceDialog.css
b/src/ui/styles/dialogs/ve.ui.FindAndReplaceDialog.css
index ba73254..3a80cda 100644
--- a/src/ui/styles/dialogs/ve.ui.FindAndReplaceDialog.css
+++ b/src/ui/styles/dialogs/ve.ui.FindAndReplaceDialog.css
@@ -39,7 +39,7 @@
position: absolute;
top: 0;
left: 0;
- pointer-events: none; /* stylelint-disable-line
no-unsupported-browser-features */
+ pointer-events: none;
}
.ve-ui-findAndReplaceDialog-findResult {
diff --git a/src/ui/styles/dialogs/ve.ui.SpecialCharacterDialog.css
b/src/ui/styles/dialogs/ve.ui.SpecialCharacterDialog.css
index 4c8e873..4fc1531 100644
--- a/src/ui/styles/dialogs/ve.ui.SpecialCharacterDialog.css
+++ b/src/ui/styles/dialogs/ve.ui.SpecialCharacterDialog.css
@@ -46,11 +46,9 @@
display: inline-block;
margin: 0 3px 3px 0;
border: 1px solid #e6e6e6;
- /* stylelint-disable no-unsupported-browser-features */
-webkit-transition: border-color 200ms;
-moz-transition: border-color 200ms;
transition: border-color 200ms;
- /* stylelint-enable no-unsupported-browser-features */
}
.ve-ui-specialCharacterPage-character:hover {
diff --git a/src/ui/styles/dialogs/ve.ui.ToolbarDialog.css
b/src/ui/styles/dialogs/ve.ui.ToolbarDialog.css
index 77befac..033e916 100644
--- a/src/ui/styles/dialogs/ve.ui.ToolbarDialog.css
+++ b/src/ui/styles/dialogs/ve.ui.ToolbarDialog.css
@@ -11,11 +11,9 @@
.ve-ui-toolbarDialog-position-above {
overflow-y: hidden;
max-height: 0;
- /* stylelint-disable no-unsupported-browser-features */
-webkit-transition: max-height 250ms;
-moz-transition: max-height 250ms;
transition: max-height 250ms;
- /* stylelint-enable no-unsupported-browser-features */
}
.oo-ui-toolbar-position-top .ve-ui-toolbarDialog-position-above {
@@ -39,20 +37,16 @@
overflow-x: hidden;
width: 0;
margin-top: 1px;
- /* stylelint-disable no-unsupported-browser-features */
-webkit-transition: width 250ms;
-moz-transition: width 250ms;
transition: width 250ms;
- /* stylelint-enable no-unsupported-browser-features */
}
.ve-ui-surface {
min-height: 0;
- /* stylelint-disable no-unsupported-browser-features */
-webkit-transition: margin 250ms, min-height 250ms;
-moz-transition: margin 250ms, min-height 250ms;
transition: margin 250ms, min-height 250ms;
- /* stylelint-enable no-unsupported-browser-features */
}
.ve-ui-surface-toolbarDialog-side {
diff --git a/src/ui/styles/elements/ve.ui.DiffElement.css
b/src/ui/styles/elements/ve.ui.DiffElement.css
index 9e8edb7..195ab0b 100644
--- a/src/ui/styles/elements/ve.ui.DiffElement.css
+++ b/src/ui/styles/elements/ve.ui.DiffElement.css
@@ -47,7 +47,7 @@
outline: 3px solid #6da9f7;
padding: 2px;
margin: -2px 0 0 -2px;
- pointer-events: none; /* stylelint-disable-line
no-unsupported-browser-features */
+ pointer-events: none;
}
.ve-ui-diffElement-attributeChange {
diff --git a/src/ui/styles/ve.ui.ContextItem.css
b/src/ui/styles/ve.ui.ContextItem.css
index fbfce94..3e9b239 100644
--- a/src/ui/styles/ve.ui.ContextItem.css
+++ b/src/ui/styles/ve.ui.ContextItem.css
@@ -6,12 +6,10 @@
.ve-ui-contextItem {
/* Disable selection to avoid stealing focus from the surface */
- /* stylelint-disable no-unsupported-browser-features */
-webkit-user-select: none;
-moz-user-select: none;
-ms-user-select: none;
user-select: none;
- /* stylelint-enable no-unsupported-browser-features */
cursor: default;
}
diff --git a/src/ui/styles/ve.ui.DebugBar.css b/src/ui/styles/ve.ui.DebugBar.css
index 4cf76ae..5847577 100644
--- a/src/ui/styles/ve.ui.DebugBar.css
+++ b/src/ui/styles/ve.ui.DebugBar.css
@@ -67,7 +67,7 @@
.ve-ui-debugBar-dump th {
padding: 0.5em 1em;
color: #555;
- text-shadow: 0 1px 1px #fff; /* stylelint-disable-line
no-unsupported-browser-features */
+ text-shadow: 0 1px 1px #fff;
}
.ve-ui-debugBar-dump ol {
@@ -81,13 +81,13 @@
border-radius: 0.3em;
margin: 0.25em 0 0.25em 0;
padding: 0.125em 0.5em;
- text-shadow: 0 1px 1px #fff; /* stylelint-disable-line
no-unsupported-browser-features */
+ text-shadow: 0 1px 1px #fff;
color: #000;
}
.ve-ui-debugBar-dump li > span > span {
color: #aaa;
- text-shadow: 0 1px 1px #fff; /* stylelint-disable-line
no-unsupported-browser-features */
+ text-shadow: 0 1px 1px #fff;
}
.ve-ui-debugBar-dump li .ve-ui-debugBar-dump-undefined {
@@ -127,5 +127,5 @@
.ve-ui-debugBar-filibuster th {
padding: 0.5em 1em;
color: #555;
- text-shadow: 0 1px 1px #fff; /* stylelint-disable-line
no-unsupported-browser-features */
+ text-shadow: 0 1px 1px #fff;
}
diff --git a/src/ui/styles/ve.ui.DesktopContext.css
b/src/ui/styles/ve.ui.DesktopContext.css
index e860de2..fcb68b5 100644
--- a/src/ui/styles/ve.ui.DesktopContext.css
+++ b/src/ui/styles/ve.ui.DesktopContext.css
@@ -39,7 +39,7 @@
}
.ve-ui-desktopContext-floating {
- position: fixed; /* stylelint-disable-line
no-unsupported-browser-features */
+ position: fixed;
}
.ve-ui-desktopContext > .oo-ui-popupWidget:not( .oo-ui-popupWidget-anchored )
.oo-ui-popupWidget-popup {
diff --git a/src/ui/styles/ve.ui.Overlay.css b/src/ui/styles/ve.ui.Overlay.css
index 807d98d..f4e3964 100644
--- a/src/ui/styles/ve.ui.Overlay.css
+++ b/src/ui/styles/ve.ui.Overlay.css
@@ -30,10 +30,8 @@
-webkit-transform: translate3d( 0, -100%, 0 );
transform: translate3d( 0, -100%, 0 );
- /* stylelint-disable no-unsupported-browser-features */
-webkit-transition: -webkit-transform 0.3s, opacity 0.3s;
transition: transform 0.3s, opacity 0.3s;
- /* stylelint-enable no-unsupported-browser-features */
}
.ve-ui-overlay-global-mobile-visible {
diff --git a/src/ui/styles/ve.ui.Toolbar.css b/src/ui/styles/ve.ui.Toolbar.css
index 9daf4a8..597136d 100644
--- a/src/ui/styles/ve.ui.Toolbar.css
+++ b/src/ui/styles/ve.ui.Toolbar.css
@@ -12,7 +12,7 @@
/* PositionedTargetToolbar */
.ve-ui-toolbar-floating > .oo-ui-toolbar-bar {
- position: fixed; /* stylelint-disable-line
no-unsupported-browser-features */
+ position: fixed;
top: 0;
z-index: 2;
border-top: 0;
--
To view, visit https://gerrit.wikimedia.org/r/346918
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibef4f2dc8508983baab2094952cf2649a99fab36
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester <jforres...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
