Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/346981 )
Change subject: Hygiene: Reduce nesting of test cases
......................................................................
Hygiene: Reduce nesting of test cases
The ABANDON_START action test cases were (accidentally?) nested under
the FETCH_COMPLETE action test cases...
Bug: T162373
Change-Id: Ia7866178162512602dedd7f70d62c17995ee5076
---
M tests/node-qunit/reducers/eventLogging.test.js
1 file changed, 13 insertions(+), 13 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups
refs/changes/81/346981/1
diff --git a/tests/node-qunit/reducers/eventLogging.test.js
b/tests/node-qunit/reducers/eventLogging.test.js
index 5a24acf..d807204 100644
--- a/tests/node-qunit/reducers/eventLogging.test.js
+++ b/tests/node-qunit/reducers/eventLogging.test.js
@@ -371,22 +371,22 @@
state,
'It should NOOP if the interaction has been finalised.'
);
+} );
- QUnit.test( 'ABANDON_START', function ( assert ) {
- var state = {
- interaction: {}
- };
+QUnit.test( 'ABANDON_START', function ( assert ) {
+ var state = {
+ interaction: {}
+ };
- state = eventLogging( state, {
- type: 'ABANDON_START',
- timestamp: Date.now()
- } );
-
- assert.notOk(
- state.interaction.isUserDwelling,
- 'It should mark the link or preview as having been
abandoned.'
- );
+ state = eventLogging( state, {
+ type: 'ABANDON_START',
+ timestamp: Date.now()
} );
+
+ assert.notOk(
+ state.interaction.isUserDwelling,
+ 'It should mark the link or preview as having been abandoned.'
+ );
} );
QUnit.test( 'ABANDON_END', function ( assert ) {
--
To view, visit https://gerrit.wikimedia.org/r/346981
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia7866178162512602dedd7f70d62c17995ee5076
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
